From 01ac8bbd2f7f54506ca5cd973b3258e5d6a23628 Mon Sep 17 00:00:00 2001
From: Megvii Engine Team <megengine@megvii.com>
Date: Wed, 13 May 2020 21:53:56 +0800
Subject: [PATCH] docs(gopt): add more comments

GitOrigin-RevId: 358f30b1b70fb70d821d6bd0e6e3db605161ea7b
---
 src/core/impl/graph/cg_impl.cpp | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/src/core/impl/graph/cg_impl.cpp b/src/core/impl/graph/cg_impl.cpp
index 88b9f23b..b4eded13 100644
--- a/src/core/impl/graph/cg_impl.cpp
+++ b/src/core/impl/graph/cg_impl.cpp
@@ -474,6 +474,13 @@ ComputingGraphImpl::CompileState ComputingGraphImpl::compile_prepare(
     }
 #endif
     gopt::GraphOptimizer optimizer;
+    /**
+     * \note We should reset options when we add passes indicated by optimize
+     * options, As there exists `ParamFuse pass` will compile subgraph which may
+     * cause ring invoking, \see
+     * https://git-core.megvii-inc.com/brain-sdk/MegBrain/merge_requests/1717
+     * for detail
+     */
     optimizer.add_passes_for_optimize_options(options().graph_opt, true);
     optimizer.apply_inplace(dest_vars);