From 544b798374a5679073d98fab9dc54b92cea1173b Mon Sep 17 00:00:00 2001 From: Megvii Engine Team Date: Tue, 17 Nov 2020 15:28:34 +0800 Subject: [PATCH] revert: feat(mge/grad_manager): add `clear_grad` method for GradManager This reverts commit aa9540e09018697110b672f3772473b68305751c. GitOrigin-RevId: 2d15e503de0728a35028516561ead04d1b90ae06 --- imperative/python/megengine/autodiff/grad_manager.py | 8 -------- imperative/python/test/unit/autodiff/test_grad_manger.py | 3 ++- 2 files changed, 2 insertions(+), 9 deletions(-) diff --git a/imperative/python/megengine/autodiff/grad_manager.py b/imperative/python/megengine/autodiff/grad_manager.py index db03f235..0cd44b38 100644 --- a/imperative/python/megengine/autodiff/grad_manager.py +++ b/imperative/python/megengine/autodiff/grad_manager.py @@ -115,14 +115,6 @@ class GradManager: else: logger.warning("params with index {} is not attached.".format(idx)) - def clear_grad(self): - r""" - For advanced usage: set the grad attribute to None for registered parameters. - It could be more convenient when there is more than one Optimizer. - """ - for param in self._param_dict.values(): - param.grad = None - def _register_after_backward_callback(self, callback): self._after_backward_callback.append(callback) return self diff --git a/imperative/python/test/unit/autodiff/test_grad_manger.py b/imperative/python/test/unit/autodiff/test_grad_manger.py index f47e618b..947fa520 100644 --- a/imperative/python/test/unit/autodiff/test_grad_manger.py +++ b/imperative/python/test/unit/autodiff/test_grad_manger.py @@ -37,7 +37,8 @@ def test_basic(): np.testing.assert_equal(w.grad.numpy(), [[1], [3], [5]]) np.testing.assert_equal(b.grad.numpy(), [1]) - gm.clear_grad() + w.grad = None + b.grad = None with gm: p = F.matmul(x, w) y = p + b