You can not select more than 25 topics Topics must start with a chinese character,a letter or number, can include dashes ('-') and can be up to 35 characters long.

issue_milestone.go 10 kB

Shows total tracked time in issue and milestone list (#3341) * Show total tracked time in issue and milestone list Show total tracked time at issue page Signed-off-by: Jonas Franz <info@jonasfranz.software> * Optimizing TotalTimes by using SumInt Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fixing wrong total times for milestones caused by a missing JOIN Adding unit tests for total times Signed-off-by: Jonas Franz <info@jonasfranz.software> * Logging error instead of ignoring it Signed-off-by: Jonas Franz <info@jonasfranz.software> * Correcting spelling mistakes Signed-off-by: Jonas Franz <info@jonasfranz.software> * Change error message to a short version Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add error handling to TotalTimes Add variable for totalTimes Signed-off-by: Jonas Franz <info@jonasfranz.de> * Introduce TotalTrackedTimes as variable of issue Load TotalTrackedTimes by loading attributes of IssueList Load TotalTrackedTimes by loading attributes of single issue Add Sec2Time as helper to use it in templates Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fixed test + gofmt Signed-off-by: Jonas Franz <info@jonasfranz.software> * Load TotalTrackedTimes via MilestoneList instead of single requests Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add documentation for MilestoneList Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add documentation for MilestoneList Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix test Signed-off-by: Jonas Franz <info@jonasfranz.software> * Change comment from SQL query to description Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix unit test by using int64 instead of int Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix unit test by using int64 instead of int Signed-off-by: Jonas Franz <info@jonasfranz.software> * Check if timetracker is enabled Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix test by enabling timetracking Signed-off-by: Jonas Franz <info@jonasfranz.de>
7 years ago
Shows total tracked time in issue and milestone list (#3341) * Show total tracked time in issue and milestone list Show total tracked time at issue page Signed-off-by: Jonas Franz <info@jonasfranz.software> * Optimizing TotalTimes by using SumInt Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fixing wrong total times for milestones caused by a missing JOIN Adding unit tests for total times Signed-off-by: Jonas Franz <info@jonasfranz.software> * Logging error instead of ignoring it Signed-off-by: Jonas Franz <info@jonasfranz.software> * Correcting spelling mistakes Signed-off-by: Jonas Franz <info@jonasfranz.software> * Change error message to a short version Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add error handling to TotalTimes Add variable for totalTimes Signed-off-by: Jonas Franz <info@jonasfranz.de> * Introduce TotalTrackedTimes as variable of issue Load TotalTrackedTimes by loading attributes of IssueList Load TotalTrackedTimes by loading attributes of single issue Add Sec2Time as helper to use it in templates Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fixed test + gofmt Signed-off-by: Jonas Franz <info@jonasfranz.software> * Load TotalTrackedTimes via MilestoneList instead of single requests Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add documentation for MilestoneList Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add documentation for MilestoneList Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix test Signed-off-by: Jonas Franz <info@jonasfranz.software> * Change comment from SQL query to description Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix unit test by using int64 instead of int Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix unit test by using int64 instead of int Signed-off-by: Jonas Franz <info@jonasfranz.software> * Check if timetracker is enabled Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix test by enabling timetracking Signed-off-by: Jonas Franz <info@jonasfranz.de>
7 years ago
Shows total tracked time in issue and milestone list (#3341) * Show total tracked time in issue and milestone list Show total tracked time at issue page Signed-off-by: Jonas Franz <info@jonasfranz.software> * Optimizing TotalTimes by using SumInt Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fixing wrong total times for milestones caused by a missing JOIN Adding unit tests for total times Signed-off-by: Jonas Franz <info@jonasfranz.software> * Logging error instead of ignoring it Signed-off-by: Jonas Franz <info@jonasfranz.software> * Correcting spelling mistakes Signed-off-by: Jonas Franz <info@jonasfranz.software> * Change error message to a short version Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add error handling to TotalTimes Add variable for totalTimes Signed-off-by: Jonas Franz <info@jonasfranz.de> * Introduce TotalTrackedTimes as variable of issue Load TotalTrackedTimes by loading attributes of IssueList Load TotalTrackedTimes by loading attributes of single issue Add Sec2Time as helper to use it in templates Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fixed test + gofmt Signed-off-by: Jonas Franz <info@jonasfranz.software> * Load TotalTrackedTimes via MilestoneList instead of single requests Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add documentation for MilestoneList Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add documentation for MilestoneList Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix test Signed-off-by: Jonas Franz <info@jonasfranz.software> * Change comment from SQL query to description Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix unit test by using int64 instead of int Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix unit test by using int64 instead of int Signed-off-by: Jonas Franz <info@jonasfranz.software> * Check if timetracker is enabled Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix test by enabling timetracking Signed-off-by: Jonas Franz <info@jonasfranz.de>
7 years ago
Shows total tracked time in issue and milestone list (#3341) * Show total tracked time in issue and milestone list Show total tracked time at issue page Signed-off-by: Jonas Franz <info@jonasfranz.software> * Optimizing TotalTimes by using SumInt Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fixing wrong total times for milestones caused by a missing JOIN Adding unit tests for total times Signed-off-by: Jonas Franz <info@jonasfranz.software> * Logging error instead of ignoring it Signed-off-by: Jonas Franz <info@jonasfranz.software> * Correcting spelling mistakes Signed-off-by: Jonas Franz <info@jonasfranz.software> * Change error message to a short version Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add error handling to TotalTimes Add variable for totalTimes Signed-off-by: Jonas Franz <info@jonasfranz.de> * Introduce TotalTrackedTimes as variable of issue Load TotalTrackedTimes by loading attributes of IssueList Load TotalTrackedTimes by loading attributes of single issue Add Sec2Time as helper to use it in templates Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fixed test + gofmt Signed-off-by: Jonas Franz <info@jonasfranz.software> * Load TotalTrackedTimes via MilestoneList instead of single requests Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add documentation for MilestoneList Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add documentation for MilestoneList Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix test Signed-off-by: Jonas Franz <info@jonasfranz.software> * Change comment from SQL query to description Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix unit test by using int64 instead of int Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix unit test by using int64 instead of int Signed-off-by: Jonas Franz <info@jonasfranz.software> * Check if timetracker is enabled Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix test by enabling timetracking Signed-off-by: Jonas Franz <info@jonasfranz.de>
7 years ago
123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408
  1. // Copyright 2017 The Gitea Authors. All rights reserved.
  2. // Use of this source code is governed by a MIT-style
  3. // license that can be found in the LICENSE file.
  4. package models
  5. import (
  6. "code.gitea.io/gitea/modules/setting"
  7. "code.gitea.io/gitea/modules/util"
  8. api "code.gitea.io/sdk/gitea"
  9. "github.com/go-xorm/xorm"
  10. )
  11. // Milestone represents a milestone of repository.
  12. type Milestone struct {
  13. ID int64 `xorm:"pk autoincr"`
  14. RepoID int64 `xorm:"INDEX"`
  15. Name string
  16. Content string `xorm:"TEXT"`
  17. RenderedContent string `xorm:"-"`
  18. IsClosed bool
  19. NumIssues int
  20. NumClosedIssues int
  21. NumOpenIssues int `xorm:"-"`
  22. Completeness int // Percentage(1-100).
  23. IsOverDue bool `xorm:"-"`
  24. DeadlineString string `xorm:"-"`
  25. DeadlineUnix util.TimeStamp
  26. ClosedDateUnix util.TimeStamp
  27. TotalTrackedTime int64 `xorm:"-"`
  28. }
  29. // BeforeUpdate is invoked from XORM before updating this object.
  30. func (m *Milestone) BeforeUpdate() {
  31. if m.NumIssues > 0 {
  32. m.Completeness = m.NumClosedIssues * 100 / m.NumIssues
  33. } else {
  34. m.Completeness = 0
  35. }
  36. }
  37. // AfterLoad is invoked from XORM after setting the value of a field of
  38. // this object.
  39. func (m *Milestone) AfterLoad() {
  40. m.NumOpenIssues = m.NumIssues - m.NumClosedIssues
  41. if m.DeadlineUnix.Year() == 9999 {
  42. return
  43. }
  44. m.DeadlineString = m.DeadlineUnix.Format("2006-01-02")
  45. if util.TimeStampNow() >= m.DeadlineUnix {
  46. m.IsOverDue = true
  47. }
  48. }
  49. // State returns string representation of milestone status.
  50. func (m *Milestone) State() api.StateType {
  51. if m.IsClosed {
  52. return api.StateClosed
  53. }
  54. return api.StateOpen
  55. }
  56. // APIFormat returns this Milestone in API format.
  57. func (m *Milestone) APIFormat() *api.Milestone {
  58. apiMilestone := &api.Milestone{
  59. ID: m.ID,
  60. State: m.State(),
  61. Title: m.Name,
  62. Description: m.Content,
  63. OpenIssues: m.NumOpenIssues,
  64. ClosedIssues: m.NumClosedIssues,
  65. }
  66. if m.IsClosed {
  67. apiMilestone.Closed = m.ClosedDateUnix.AsTimePtr()
  68. }
  69. if m.DeadlineUnix.Year() < 9999 {
  70. apiMilestone.Deadline = m.DeadlineUnix.AsTimePtr()
  71. }
  72. return apiMilestone
  73. }
  74. // NewMilestone creates new milestone of repository.
  75. func NewMilestone(m *Milestone) (err error) {
  76. sess := x.NewSession()
  77. defer sess.Close()
  78. if err = sess.Begin(); err != nil {
  79. return err
  80. }
  81. if _, err = sess.Insert(m); err != nil {
  82. return err
  83. }
  84. if _, err = sess.Exec("UPDATE `repository` SET num_milestones = num_milestones + 1 WHERE id = ?", m.RepoID); err != nil {
  85. return err
  86. }
  87. return sess.Commit()
  88. }
  89. func getMilestoneByRepoID(e Engine, repoID, id int64) (*Milestone, error) {
  90. m := &Milestone{
  91. ID: id,
  92. RepoID: repoID,
  93. }
  94. has, err := e.Get(m)
  95. if err != nil {
  96. return nil, err
  97. } else if !has {
  98. return nil, ErrMilestoneNotExist{id, repoID}
  99. }
  100. return m, nil
  101. }
  102. // GetMilestoneByRepoID returns the milestone in a repository.
  103. func GetMilestoneByRepoID(repoID, id int64) (*Milestone, error) {
  104. return getMilestoneByRepoID(x, repoID, id)
  105. }
  106. // MilestoneList is a list of milestones offering additional functionality
  107. type MilestoneList []*Milestone
  108. func (milestones MilestoneList) loadTotalTrackedTimes(e Engine) error {
  109. type totalTimesByMilestone struct {
  110. MilestoneID int64
  111. Time int64
  112. }
  113. if len(milestones) == 0 {
  114. return nil
  115. }
  116. var trackedTimes = make(map[int64]int64, len(milestones))
  117. // Get total tracked time by milestone_id
  118. rows, err := e.Table("issue").
  119. Join("INNER", "milestone", "issue.milestone_id = milestone.id").
  120. Join("LEFT", "tracked_time", "tracked_time.issue_id = issue.id").
  121. Select("milestone_id, sum(time) as time").
  122. In("milestone_id", milestones.getMilestoneIDs()).
  123. GroupBy("milestone_id").
  124. Rows(new(totalTimesByMilestone))
  125. if err != nil {
  126. return err
  127. }
  128. defer rows.Close()
  129. for rows.Next() {
  130. var totalTime totalTimesByMilestone
  131. err = rows.Scan(&totalTime)
  132. if err != nil {
  133. return err
  134. }
  135. trackedTimes[totalTime.MilestoneID] = totalTime.Time
  136. }
  137. for _, milestone := range milestones {
  138. milestone.TotalTrackedTime = trackedTimes[milestone.ID]
  139. }
  140. return nil
  141. }
  142. // LoadTotalTrackedTimes loads for every milestone in the list the TotalTrackedTime by a batch request
  143. func (milestones MilestoneList) LoadTotalTrackedTimes() error {
  144. return milestones.loadTotalTrackedTimes(x)
  145. }
  146. func (milestones MilestoneList) getMilestoneIDs() []int64 {
  147. var ids = make([]int64, 0, len(milestones))
  148. for _, ms := range milestones {
  149. ids = append(ids, ms.ID)
  150. }
  151. return ids
  152. }
  153. // GetMilestonesByRepoID returns all milestones of a repository.
  154. func GetMilestonesByRepoID(repoID int64) (MilestoneList, error) {
  155. miles := make([]*Milestone, 0, 10)
  156. return miles, x.Where("repo_id = ?", repoID).Find(&miles)
  157. }
  158. // GetMilestones returns a list of milestones of given repository and status.
  159. func GetMilestones(repoID int64, page int, isClosed bool, sortType string) (MilestoneList, error) {
  160. miles := make([]*Milestone, 0, setting.UI.IssuePagingNum)
  161. sess := x.Where("repo_id = ? AND is_closed = ?", repoID, isClosed)
  162. if page > 0 {
  163. sess = sess.Limit(setting.UI.IssuePagingNum, (page-1)*setting.UI.IssuePagingNum)
  164. }
  165. switch sortType {
  166. case "furthestduedate":
  167. sess.Desc("deadline_unix")
  168. case "leastcomplete":
  169. sess.Asc("completeness")
  170. case "mostcomplete":
  171. sess.Desc("completeness")
  172. case "leastissues":
  173. sess.Asc("num_issues")
  174. case "mostissues":
  175. sess.Desc("num_issues")
  176. default:
  177. sess.Asc("deadline_unix")
  178. }
  179. return miles, sess.Find(&miles)
  180. }
  181. func updateMilestone(e Engine, m *Milestone) error {
  182. _, err := e.ID(m.ID).AllCols().Update(m)
  183. return err
  184. }
  185. // UpdateMilestone updates information of given milestone.
  186. func UpdateMilestone(m *Milestone) error {
  187. return updateMilestone(x, m)
  188. }
  189. func countRepoMilestones(e Engine, repoID int64) (int64, error) {
  190. return e.
  191. Where("repo_id=?", repoID).
  192. Count(new(Milestone))
  193. }
  194. func countRepoClosedMilestones(e Engine, repoID int64) (int64, error) {
  195. return e.
  196. Where("repo_id=? AND is_closed=?", repoID, true).
  197. Count(new(Milestone))
  198. }
  199. // CountRepoClosedMilestones returns number of closed milestones in given repository.
  200. func CountRepoClosedMilestones(repoID int64) (int64, error) {
  201. return countRepoClosedMilestones(x, repoID)
  202. }
  203. // MilestoneStats returns number of open and closed milestones of given repository.
  204. func MilestoneStats(repoID int64) (open int64, closed int64, err error) {
  205. open, err = x.
  206. Where("repo_id=? AND is_closed=?", repoID, false).
  207. Count(new(Milestone))
  208. if err != nil {
  209. return 0, 0, nil
  210. }
  211. closed, err = CountRepoClosedMilestones(repoID)
  212. return open, closed, err
  213. }
  214. // ChangeMilestoneStatus changes the milestone open/closed status.
  215. func ChangeMilestoneStatus(m *Milestone, isClosed bool) (err error) {
  216. repo, err := GetRepositoryByID(m.RepoID)
  217. if err != nil {
  218. return err
  219. }
  220. sess := x.NewSession()
  221. defer sess.Close()
  222. if err = sess.Begin(); err != nil {
  223. return err
  224. }
  225. m.IsClosed = isClosed
  226. if err = updateMilestone(sess, m); err != nil {
  227. return err
  228. }
  229. numMilestones, err := countRepoMilestones(sess, repo.ID)
  230. if err != nil {
  231. return err
  232. }
  233. numClosedMilestones, err := countRepoClosedMilestones(sess, repo.ID)
  234. if err != nil {
  235. return err
  236. }
  237. repo.NumMilestones = int(numMilestones)
  238. repo.NumClosedMilestones = int(numClosedMilestones)
  239. if _, err = sess.ID(repo.ID).Cols("num_milestones, num_closed_milestones").Update(repo); err != nil {
  240. return err
  241. }
  242. return sess.Commit()
  243. }
  244. func changeMilestoneIssueStats(e *xorm.Session, issue *Issue) error {
  245. if issue.MilestoneID == 0 {
  246. return nil
  247. }
  248. m, err := getMilestoneByRepoID(e, issue.RepoID, issue.MilestoneID)
  249. if err != nil {
  250. return err
  251. }
  252. if issue.IsClosed {
  253. m.NumOpenIssues--
  254. m.NumClosedIssues++
  255. } else {
  256. m.NumOpenIssues++
  257. m.NumClosedIssues--
  258. }
  259. return updateMilestone(e, m)
  260. }
  261. func changeMilestoneAssign(e *xorm.Session, doer *User, issue *Issue, oldMilestoneID int64) error {
  262. if oldMilestoneID > 0 {
  263. m, err := getMilestoneByRepoID(e, issue.RepoID, oldMilestoneID)
  264. if err != nil {
  265. return err
  266. }
  267. m.NumIssues--
  268. if issue.IsClosed {
  269. m.NumClosedIssues--
  270. }
  271. if err = updateMilestone(e, m); err != nil {
  272. return err
  273. }
  274. }
  275. if issue.MilestoneID > 0 {
  276. m, err := getMilestoneByRepoID(e, issue.RepoID, issue.MilestoneID)
  277. if err != nil {
  278. return err
  279. }
  280. m.NumIssues++
  281. if issue.IsClosed {
  282. m.NumClosedIssues++
  283. }
  284. if err = updateMilestone(e, m); err != nil {
  285. return err
  286. }
  287. }
  288. if err := issue.loadRepo(e); err != nil {
  289. return err
  290. }
  291. if oldMilestoneID > 0 || issue.MilestoneID > 0 {
  292. if _, err := createMilestoneComment(e, doer, issue.Repo, issue, oldMilestoneID, issue.MilestoneID); err != nil {
  293. return err
  294. }
  295. }
  296. return updateIssueCols(e, issue, "milestone_id")
  297. }
  298. // ChangeMilestoneAssign changes assignment of milestone for issue.
  299. func ChangeMilestoneAssign(issue *Issue, doer *User, oldMilestoneID int64) (err error) {
  300. sess := x.NewSession()
  301. defer sess.Close()
  302. if err = sess.Begin(); err != nil {
  303. return err
  304. }
  305. if err = changeMilestoneAssign(sess, doer, issue, oldMilestoneID); err != nil {
  306. return err
  307. }
  308. return sess.Commit()
  309. }
  310. // DeleteMilestoneByRepoID deletes a milestone from a repository.
  311. func DeleteMilestoneByRepoID(repoID, id int64) error {
  312. m, err := GetMilestoneByRepoID(repoID, id)
  313. if err != nil {
  314. if IsErrMilestoneNotExist(err) {
  315. return nil
  316. }
  317. return err
  318. }
  319. repo, err := GetRepositoryByID(m.RepoID)
  320. if err != nil {
  321. return err
  322. }
  323. sess := x.NewSession()
  324. defer sess.Close()
  325. if err = sess.Begin(); err != nil {
  326. return err
  327. }
  328. if _, err = sess.ID(m.ID).Delete(new(Milestone)); err != nil {
  329. return err
  330. }
  331. numMilestones, err := countRepoMilestones(sess, repo.ID)
  332. if err != nil {
  333. return err
  334. }
  335. numClosedMilestones, err := countRepoClosedMilestones(sess, repo.ID)
  336. if err != nil {
  337. return err
  338. }
  339. repo.NumMilestones = int(numMilestones)
  340. repo.NumClosedMilestones = int(numClosedMilestones)
  341. if _, err = sess.ID(repo.ID).Cols("num_milestones, num_closed_milestones").Update(repo); err != nil {
  342. return err
  343. }
  344. if _, err = sess.Exec("UPDATE `issue` SET milestone_id = 0 WHERE milestone_id = ?", m.ID); err != nil {
  345. return err
  346. }
  347. return sess.Commit()
  348. }