diff --git a/models/dataset.go b/models/dataset.go index 0e93da628..2b54e539e 100644 --- a/models/dataset.go +++ b/models/dataset.go @@ -291,30 +291,11 @@ func GetOwnerDatasetByID(id int64, user *User) (*Dataset, error) { return nil, errors.New("dataset not fount") } -func IncreaseDownloadCount(datasetID int64, uid int64) error { - var err error - sess := x.NewSession() - defer sess.Close() - if err = sess.Begin(); err != nil { - return err - } - - dataset := &Dataset{ID: datasetID, UserID: uid} - has, err := sess.Get(dataset) - if err != nil { - return err - } else if !has { - return errors.New("not found") - } - +func IncreaseDownloadCount(datasetID int64) error { // Update download count. - if _, err := sess.Exec("UPDATE `dataset` SET download_times=download_times+1 WHERE id=?", datasetID); err != nil { + if _, err := x.Exec("UPDATE `dataset` SET download_times=download_times+1 WHERE id=?", datasetID); err != nil { return fmt.Errorf("increase dataset count: %v", err) } - if err = sess.Commit(); err != nil { - sess.Close() - return fmt.Errorf("Commit: %v", err) - } return nil } diff --git a/routers/repo/attachment.go b/routers/repo/attachment.go index e5940a5a9..05b94ca22 100644 --- a/routers/repo/attachment.go +++ b/routers/repo/attachment.go @@ -186,7 +186,7 @@ func increaseDownloadCount(attach *models.Attachment, dataSet *models.Dataset) e } if dataSet != nil { - if err := models.IncreaseDownloadCount(dataSet.ID, dataSet.UserID); err != nil { + if err := models.IncreaseDownloadCount(dataSet.ID); err != nil { return err } }