fix-3244

models/cloudbrain_static.go

@@ -314,7 +314,7 @@ func GetCloudbrainByTime(beginTime int64, endTime int64) ([]*CloudbrainInfo, err
 		builder.And(builder.Gte{"cloudbrain.start_time": beginTime}, builder.Lte{"cloudbrain.start_time": endTime}, builder.Gt{"cloudbrain.start_time": 0}),
 	)
 	cond = cond.Or(
-		builder.And(builder.Eq{"cloudbrain.status": string(JobRunning)}),
+		builder.And(builder.Eq{"cloudbrain.status": string(JobRunning)}, builder.Lte{"cloudbrain.start_time": beginTime}),
 	)
 	sess.OrderBy("cloudbrain.id ASC")
 	cloudbrains := make([]*CloudbrainInfo, 0, 10)

modules/cron/tasks_basic.go

@@ -5,10 +5,11 @@
 package cron
 
 import (
-	"code.gitea.io/gitea/modules/setting"
 	"context"
 	"time"
 
+	"code.gitea.io/gitea/modules/setting"
+
 	"code.gitea.io/gitea/modules/urfs_client/urchin"
 	cloudbrainService "code.gitea.io/gitea/services/cloudbrain"
 
@@ -296,7 +297,7 @@ func registerHandleCloudbrainDurationStatistic() {
 	RegisterTaskFatal("handle_cloudbrain_duration_statistic", &BaseConfig{
 		Enabled:    true,
 		RunAtStart: false,
-		Schedule:   "1 0 * * * ?",
+		Schedule:   "1 1 * * * ?",
 	}, func(ctx context.Context, _ *models.User, _ Config) error {
 		repo.CloudbrainDurationStatisticHour()
 		return nil

routers/repo/cloudbrain_statistic.go

@@ -14,13 +14,7 @@ import (
 )
 
 func CloudbrainDurationStatisticHour() {
-	defer func() {
-		err := recover()
-		if err == nil {
-			return
-		}
-	}()
-	if setting.IsCloudbrainTimingEnabled {		
+	if setting.IsCloudbrainTimingEnabled {
 		var statisticTime time.Time
 		var count int64
 		recordDurationUpdateTime, err := models.GetDurationRecordUpdateTime()
@@ -35,17 +29,16 @@ func CloudbrainDurationStatisticHour() {
 			statisticTime = currentTime
 		}
 
-		err = models.DeleteCloudbrainDurationStatistic(timeutil.TimeStamp(statisticTime.Add(-1*time.Hour).Unix()), timeutil.TimeStamp(currentTime.Unix()))
+		err = models.DeleteCloudbrainDurationStatistic(timeutil.TimeStamp(statisticTime.Unix()), timeutil.TimeStamp(currentTime.Unix()))
 		if err != nil {
 			log.Error("DeleteCloudbrainDurationStatistic failed", err)
 		}
-
+		statisticTime = statisticTime.Add(+1 * time.Hour)
 		for statisticTime.Before(currentTime) || statisticTime.Equal(currentTime) {
 			countEach := summaryDurationStat(statisticTime)
 			count += countEach
 			statisticTime = statisticTime.Add(+1 * time.Hour)
 		}
-		log.Info("summaryDurationStat count: %v", count)
 	}
 }
 func UpdateDurationStatisticHistoryData(beginTime time.Time, endTime time.Time) int64 {
@@ -71,15 +64,18 @@ func summaryDurationStat(statisticTime time.Time) int64 {
 
 	ciTasks, err := models.GetCloudbrainByTime(beginTime, endTime)
 	if err != nil {
-		log.Info("GetCloudbrainByTime err: %v", err)
+		log.Error("GetCloudbrainByTime err: %v", err)
 		return 0
 	}
-	models.LoadSpecs4CloudbrainInfo(ciTasks)
-	cloudBrainCenterCodeAndCardTypeInfo, cloudbrainMap := getcloudBrainCenterCodeAndCardTypeInfo(ciTasks, beginTime, endTime)
+	err = models.LoadSpecs4CloudbrainInfo(ciTasks)
+	if err != nil {
+		log.Error("LoadSpecs4CloudbrainInfo err: %v", err)
+	}
+	cloudBrainCenterCodeAndCardTypeInfo := getcloudBrainCenterCodeAndCardTypeInfo(ciTasks, int(beginTime), int(endTime))
 
 	resourceQueues, err := models.GetCanUseCardInfo()
 	if err != nil {
-		log.Info("GetCanUseCardInfo err: %v", err)
+		log.Error("GetCanUseCardInfo err: %v", err)
 		return 0
 	}
 
@@ -91,56 +87,45 @@ func summaryDurationStat(statisticTime time.Time) int64 {
 			cardsTotalDurationMap[resourceQueue.Cluster+"/"+resourceQueue.AiCenterCode+"/"+resourceQueue.AccCardType] += resourceQueue.CardsTotalNum * 1 * 60 * 60
 		}
 	}
-
-	for centerCode, CardTypes := range cloudBrainCenterCodeAndCardTypeInfo {
-		for cardType, cardDuration := range CardTypes {
-			cloudbrainTable := cloudbrainMap[centerCode+"/"+cardType]
-			if cloudbrainTable != nil {
-				if _, ok := cardsTotalDurationMap[cloudbrainTable.Cluster+"/"+centerCode+"/"+cardType]; !ok {
-					cardsTotalDurationMap[cloudbrainTable.Cluster+"/"+centerCode+"/"+cardType] = 0
-				}
-				cloudbrainDurationStat := models.CloudbrainDurationStatistic{
-					DateTimeUnix:       dateTimeUnix,
-					DayTime:            dayTime,
-					HourTime:           hourTime,
-					Cluster:            cloudbrainTable.Cluster,
-					AiCenterName:       GetAiCenterNameByCode(centerCode, "zh-CN"),
-					AiCenterCode:       centerCode,
-					AccCardType:        cardType,
-					CardsUseDuration:   cardDuration,
-					CardsTotalDuration: cardsTotalDurationMap[cloudbrainTable.Cluster+"/"+centerCode+"/"+cardType],
-					CreatedUnix:        timeutil.TimeStampNow(),
-				}
-				if _, err = models.InsertCloudbrainDurationStatistic(&cloudbrainDurationStat); err != nil {
-					log.Error("Insert cloudbrainDurationStat failed: %v", err.Error())
-				}
-				count++
-				delete(cardsTotalDurationMap, cloudbrainTable.Cluster+"/"+centerCode+"/"+cardType)
-			}
-		}
-	}
-
 	for key, cardsTotalDuration := range cardsTotalDurationMap {
-		cloudbrainDurationStat := models.CloudbrainDurationStatistic{
-			DateTimeUnix:       dateTimeUnix,
-			DayTime:            dayTime,
-			HourTime:           hourTime,
-			Cluster:            strings.Split(key, "/")[0],
-			AiCenterName:       GetAiCenterNameByCode(strings.Split(key, "/")[1], "zh-CN"),
-			AiCenterCode:       strings.Split(key, "/")[1],
-			AccCardType:        strings.Split(key, "/")[2],
-			CardsUseDuration:   0,
-			CardsTotalDuration: cardsTotalDuration,
-			CardsTotalNum:      cardsTotalDuration / 1 / 60 / 60,
-			CreatedUnix:        timeutil.TimeStampNow(),
-		}
-		if _, err = models.InsertCloudbrainDurationStatistic(&cloudbrainDurationStat); err != nil {
-			log.Error("Insert cloudbrainDurationStat failed: %v", err.Error())
+		if _, ok := cloudBrainCenterCodeAndCardTypeInfo[strings.Split(key, "/")[0]+"/"+strings.Split(key, "/")[1]][strings.Split(key, "/")[2]]; ok {
+			cloudbrainDurationStat := models.CloudbrainDurationStatistic{
+				DateTimeUnix:       dateTimeUnix,
+				DayTime:            dayTime,
+				HourTime:           hourTime,
+				Cluster:            strings.Split(key, "/")[0],
+				AiCenterName:       GetAiCenterNameByCode(strings.Split(key, "/")[1], "zh-CN"),
+				AiCenterCode:       strings.Split(key, "/")[1],
+				AccCardType:        strings.Split(key, "/")[2],
+				CardsUseDuration:   cloudBrainCenterCodeAndCardTypeInfo[strings.Split(key, "/")[0]+"/"+strings.Split(key, "/")[1]][strings.Split(key, "/")[2]],
+				CardsTotalDuration: cardsTotalDuration,
+				CardsTotalNum:      cardsTotalDuration / 1 / 60 / 60,
+				CreatedUnix:        timeutil.TimeStampNow(),
+			}
+			if _, err = models.InsertCloudbrainDurationStatistic(&cloudbrainDurationStat); err != nil {
+				log.Error("Insert cloudbrainDurationStat failed: %v", err.Error())
+			}
+			count++
+		} else {
+			cloudbrainDurationStat := models.CloudbrainDurationStatistic{
+				DateTimeUnix:       dateTimeUnix,
+				DayTime:            dayTime,
+				HourTime:           hourTime,
+				Cluster:            strings.Split(key, "/")[0],
+				AiCenterName:       GetAiCenterNameByCode(strings.Split(key, "/")[1], "zh-CN"),
+				AiCenterCode:       strings.Split(key, "/")[1],
+				AccCardType:        strings.Split(key, "/")[2],
+				CardsUseDuration:   0,
+				CardsTotalDuration: cardsTotalDuration,
+				CardsTotalNum:      cardsTotalDuration / 1 / 60 / 60,
+				CreatedUnix:        timeutil.TimeStampNow(),
+			}
+			if _, err = models.InsertCloudbrainDurationStatistic(&cloudbrainDurationStat); err != nil {
+				log.Error("Insert cloudbrainDurationStat failed: %v", err.Error())
+			}
+			count++
 		}
-		count++
 	}
-
-	log.Info("finish summary cloudbrainDurationStat")
 	return count
 }
 
@@ -159,33 +144,21 @@ func GetAiCenterNameByCode(centerCode string, language string) string {
 	return aiCenterName
 }
 
-func getcloudBrainCenterCodeAndCardTypeInfo(ciTasks []*models.CloudbrainInfo, beginTime int64, endTime int64) (map[string]map[string]int, map[string]*models.Cloudbrain) {
+func getcloudBrainCenterCodeAndCardTypeInfo(ciTasks []*models.CloudbrainInfo, hourBeginTime int, hourEndTime int) map[string]map[string]int {
 	var WorkServerNumber int
 	var AccCardsNum int
-	cloudbrainMap := make(map[string]*models.Cloudbrain)
 	cloudBrainCenterCodeAndCardType := make(map[string]map[string]int)
 	for _, cloudbrain := range ciTasks {
-		if cloudbrain.Cloudbrain.StartTime == 0 {
-			cloudbrain.Cloudbrain.StartTime = cloudbrain.Cloudbrain.CreatedUnix
-		}
-		if cloudbrain.Cloudbrain.EndTime == 0 {
-			cloudbrain.Cloudbrain.EndTime = timeutil.TimeStamp(time.Now().Unix())
-		}
-		cloudbrain = cloudbrainService.UpdateCloudbrainAiCenter(cloudbrain)
-		if cloudbrain.Cloudbrain.Spec != nil {
-			if _, ok := cloudbrainMap[cloudbrain.Cloudbrain.AiCenter+"/"+cloudbrain.Cloudbrain.Spec.AccCardType]; !ok {
-				if cloudbrain.Cloudbrain.Spec != nil {
-					cloudbrainMap[cloudbrain.Cloudbrain.AiCenter+"/"+cloudbrain.Cloudbrain.Spec.AccCardType] = &cloudbrain.Cloudbrain
-				}
-			}
-		}
-
 		cloudbrain = cloudbrainService.UpdateCloudbrainAiCenter(cloudbrain)
 		if cloudbrain.Cloudbrain.StartTime == 0 {
 			cloudbrain.Cloudbrain.StartTime = cloudbrain.Cloudbrain.CreatedUnix
 		}
 		if cloudbrain.Cloudbrain.EndTime == 0 {
-			cloudbrain.Cloudbrain.EndTime = cloudbrain.Cloudbrain.UpdatedUnix
+			if cloudbrain.Cloudbrain.Status == string(models.JobRunning) {
+				cloudbrain.Cloudbrain.EndTime = timeutil.TimeStamp(time.Now().Unix())
+			} else {
+				cloudbrain.Cloudbrain.EndTime = cloudbrain.Cloudbrain.StartTime + timeutil.TimeStamp(cloudbrain.Cloudbrain.Duration)
+			}
 		}
 		if cloudbrain.Cloudbrain.WorkServerNumber >= 1 {
 			WorkServerNumber = cloudbrain.Cloudbrain.WorkServerNumber
@@ -197,55 +170,36 @@ func getcloudBrainCenterCodeAndCardTypeInfo(ciTasks []*models.CloudbrainInfo, be
 		} else {
 			AccCardsNum = cloudbrain.Cloudbrain.Spec.AccCardsNum
 		}
-		if _, ok := cloudBrainCenterCodeAndCardType[cloudbrain.Cloudbrain.AiCenter]; !ok {
-			cloudBrainCenterCodeAndCardType[cloudbrain.Cloudbrain.AiCenter] = make(map[string]int)
+		if _, ok := cloudBrainCenterCodeAndCardType[cloudbrain.Cloudbrain.Cluster+"/"+cloudbrain.Cloudbrain.AiCenter]; !ok {
+			cloudBrainCenterCodeAndCardType[cloudbrain.Cloudbrain.Cluster+"/"+cloudbrain.Cloudbrain.AiCenter] = make(map[string]int)
 		}
+		taskStartTime := int(cloudbrain.Cloudbrain.StartTime)
+		taskEndTime := int(cloudbrain.Cloudbrain.EndTime)
 		if cloudbrain.Cloudbrain.Spec != nil {
-			if cloudbrain.Cloudbrain.Status == string(models.ModelArtsRunning) && cloudbrain.Cloudbrain.DeletedAt.IsZero() {
-				if _, ok := cloudBrainCenterCodeAndCardType[cloudbrain.Cloudbrain.AiCenter][cloudbrain.Cloudbrain.Spec.AccCardType]; !ok {
-					if int64(cloudbrain.Cloudbrain.StartTime) < beginTime {
-						cloudBrainCenterCodeAndCardType[cloudbrain.Cloudbrain.AiCenter][cloudbrain.Cloudbrain.Spec.AccCardType] = AccCardsNum * WorkServerNumber * (int(endTime) - int(beginTime))
-					} else if beginTime <= int64(cloudbrain.Cloudbrain.StartTime) && int64(cloudbrain.Cloudbrain.StartTime) < endTime {
-						cloudBrainCenterCodeAndCardType[cloudbrain.Cloudbrain.AiCenter][cloudbrain.Cloudbrain.Spec.AccCardType] = AccCardsNum * WorkServerNumber * (int(endTime) - int(cloudbrain.Cloudbrain.StartTime))
-					} else if int64(cloudbrain.Cloudbrain.StartTime) >= endTime {
-						cloudBrainCenterCodeAndCardType[cloudbrain.Cloudbrain.AiCenter][cloudbrain.Cloudbrain.Spec.AccCardType] = 0
-					}
-				} else {
-					if int64(cloudbrain.Cloudbrain.StartTime) < beginTime {
-						cloudBrainCenterCodeAndCardType[cloudbrain.Cloudbrain.AiCenter][cloudbrain.Cloudbrain.Spec.AccCardType] += AccCardsNum * WorkServerNumber * (int(endTime) - int(beginTime))
-					} else if beginTime <= int64(cloudbrain.Cloudbrain.StartTime) && int64(cloudbrain.Cloudbrain.StartTime) < endTime {
-						cloudBrainCenterCodeAndCardType[cloudbrain.Cloudbrain.AiCenter][cloudbrain.Cloudbrain.Spec.AccCardType] += AccCardsNum * WorkServerNumber * (int(endTime) - int(cloudbrain.Cloudbrain.StartTime))
-					} else if int64(cloudbrain.Cloudbrain.StartTime) >= endTime {
-						cloudBrainCenterCodeAndCardType[cloudbrain.Cloudbrain.AiCenter][cloudbrain.Cloudbrain.Spec.AccCardType] += 0
-					}
+			if _, ok := cloudBrainCenterCodeAndCardType[cloudbrain.Cloudbrain.Cluster+"/"+cloudbrain.Cloudbrain.AiCenter][cloudbrain.Cloudbrain.Spec.AccCardType]; !ok {
+				if taskStartTime < hourBeginTime && taskEndTime >= hourBeginTime && taskEndTime <= hourEndTime {
+					cloudBrainCenterCodeAndCardType[cloudbrain.Cloudbrain.Cluster+"/"+cloudbrain.Cloudbrain.AiCenter][cloudbrain.Cloudbrain.Spec.AccCardType] = AccCardsNum * WorkServerNumber * (taskEndTime - hourBeginTime)
+				} else if taskStartTime < hourBeginTime && taskEndTime > hourEndTime {
+					cloudBrainCenterCodeAndCardType[cloudbrain.Cloudbrain.Cluster+"/"+cloudbrain.Cloudbrain.AiCenter][cloudbrain.Cloudbrain.Spec.AccCardType] = AccCardsNum * WorkServerNumber * (hourEndTime - hourBeginTime)
+				} else if taskStartTime >= hourBeginTime && taskStartTime <= hourEndTime && taskEndTime >= hourBeginTime && taskEndTime <= hourEndTime {
+					cloudBrainCenterCodeAndCardType[cloudbrain.Cloudbrain.Cluster+"/"+cloudbrain.Cloudbrain.AiCenter][cloudbrain.Cloudbrain.Spec.AccCardType] = AccCardsNum * WorkServerNumber * (taskEndTime - taskStartTime)
+				} else if taskStartTime >= hourBeginTime && taskStartTime <= hourEndTime && taskEndTime > hourEndTime {
+					cloudBrainCenterCodeAndCardType[cloudbrain.Cloudbrain.Cluster+"/"+cloudbrain.Cloudbrain.AiCenter][cloudbrain.Cloudbrain.Spec.AccCardType] = AccCardsNum * WorkServerNumber * (hourEndTime - taskStartTime)
 				}
 			} else {
-				if _, ok := cloudBrainCenterCodeAndCardType[cloudbrain.Cloudbrain.AiCenter][cloudbrain.Cloudbrain.Spec.AccCardType]; !ok {
-					if int64(cloudbrain.Cloudbrain.StartTime) <= beginTime && int64(cloudbrain.Cloudbrain.EndTime) <= endTime {
-						cloudBrainCenterCodeAndCardType[cloudbrain.Cloudbrain.AiCenter][cloudbrain.Cloudbrain.Spec.AccCardType] = AccCardsNum * WorkServerNumber * (int(cloudbrain.Cloudbrain.EndTime) - int(beginTime))
-					} else if int64(cloudbrain.Cloudbrain.StartTime) <= beginTime && int64(cloudbrain.Cloudbrain.EndTime) > endTime {
-						cloudBrainCenterCodeAndCardType[cloudbrain.Cloudbrain.AiCenter][cloudbrain.Cloudbrain.Spec.AccCardType] = AccCardsNum * WorkServerNumber * (int(endTime) - int(beginTime))
-					} else if beginTime <= int64(cloudbrain.Cloudbrain.StartTime) && int64(cloudbrain.Cloudbrain.StartTime) <= endTime && int64(cloudbrain.Cloudbrain.EndTime) <= endTime {
-						cloudBrainCenterCodeAndCardType[cloudbrain.Cloudbrain.AiCenter][cloudbrain.Cloudbrain.Spec.AccCardType] = AccCardsNum * WorkServerNumber * (int(cloudbrain.Cloudbrain.EndTime) - int(cloudbrain.Cloudbrain.StartTime))
-					} else if beginTime <= int64(cloudbrain.Cloudbrain.StartTime) && int64(cloudbrain.Cloudbrain.StartTime) <= endTime && int64(cloudbrain.Cloudbrain.EndTime) > endTime {
-						cloudBrainCenterCodeAndCardType[cloudbrain.Cloudbrain.AiCenter][cloudbrain.Cloudbrain.Spec.AccCardType] = AccCardsNum * WorkServerNumber * (int(endTime) - int(cloudbrain.Cloudbrain.StartTime))
-					}
-				} else {
-					if int64(cloudbrain.Cloudbrain.StartTime) <= beginTime && int64(cloudbrain.Cloudbrain.EndTime) <= endTime {
-						cloudBrainCenterCodeAndCardType[cloudbrain.Cloudbrain.AiCenter][cloudbrain.Cloudbrain.Spec.AccCardType] += AccCardsNum * WorkServerNumber * (int(cloudbrain.Cloudbrain.EndTime) - int(beginTime))
-					} else if int64(cloudbrain.Cloudbrain.StartTime) <= beginTime && int64(cloudbrain.Cloudbrain.EndTime) > endTime {
-						cloudBrainCenterCodeAndCardType[cloudbrain.Cloudbrain.AiCenter][cloudbrain.Cloudbrain.Spec.AccCardType] += AccCardsNum * WorkServerNumber * (int(endTime) - int(beginTime))
-					} else if beginTime <= int64(cloudbrain.Cloudbrain.StartTime) && int64(cloudbrain.Cloudbrain.StartTime) <= endTime && int64(cloudbrain.Cloudbrain.EndTime) <= endTime {
-						cloudBrainCenterCodeAndCardType[cloudbrain.Cloudbrain.AiCenter][cloudbrain.Cloudbrain.Spec.AccCardType] += AccCardsNum * WorkServerNumber * (int(cloudbrain.Cloudbrain.EndTime) - int(cloudbrain.Cloudbrain.StartTime))
-					} else if beginTime <= int64(cloudbrain.Cloudbrain.StartTime) && int64(cloudbrain.Cloudbrain.StartTime) <= endTime && int64(cloudbrain.Cloudbrain.EndTime) > endTime {
-						cloudBrainCenterCodeAndCardType[cloudbrain.Cloudbrain.AiCenter][cloudbrain.Cloudbrain.Spec.AccCardType] += AccCardsNum * WorkServerNumber * (int(endTime) - int(cloudbrain.Cloudbrain.StartTime))
-					}
+				if taskStartTime < hourBeginTime && taskEndTime >= hourBeginTime && taskEndTime <= hourEndTime {
+					cloudBrainCenterCodeAndCardType[cloudbrain.Cloudbrain.Cluster+"/"+cloudbrain.Cloudbrain.AiCenter][cloudbrain.Cloudbrain.Spec.AccCardType] += AccCardsNum * WorkServerNumber * (taskEndTime - hourBeginTime)
+				} else if taskStartTime < hourBeginTime && taskEndTime > hourEndTime {
+					cloudBrainCenterCodeAndCardType[cloudbrain.Cloudbrain.Cluster+"/"+cloudbrain.Cloudbrain.AiCenter][cloudbrain.Cloudbrain.Spec.AccCardType] += AccCardsNum * WorkServerNumber * (hourEndTime - hourBeginTime)
+				} else if taskStartTime >= hourBeginTime && taskStartTime <= hourEndTime && taskEndTime >= hourBeginTime && taskEndTime <= hourEndTime {
+					cloudBrainCenterCodeAndCardType[cloudbrain.Cloudbrain.Cluster+"/"+cloudbrain.Cloudbrain.AiCenter][cloudbrain.Cloudbrain.Spec.AccCardType] += AccCardsNum * WorkServerNumber * (taskEndTime - taskStartTime)
+				} else if taskStartTime >= hourBeginTime && taskStartTime <= hourEndTime && taskEndTime > hourEndTime {
+					cloudBrainCenterCodeAndCardType[cloudbrain.Cloudbrain.Cluster+"/"+cloudbrain.Cloudbrain.AiCenter][cloudbrain.Cloudbrain.Spec.AccCardType] += AccCardsNum * WorkServerNumber * (hourEndTime - taskStartTime)
 				}
 			}
 		}
 	}
-
-	return cloudBrainCenterCodeAndCardType, cloudbrainMap
+	return cloudBrainCenterCodeAndCardType
 }
 
 func CloudbrainUpdateHistoryData(ctx *context.Context) {