diff --git a/custom/templates/base/footer_content.tmpl b/custom/templates/base/footer_content.tmpl index 25b5f42e9..2a144f821 100644 --- a/custom/templates/base/footer_content.tmpl +++ b/custom/templates/base/footer_content.tmpl @@ -38,22 +38,4 @@ - diff --git a/routers/dataset/dataset.go b/routers/dataset/dataset.go index 84aeda688..cef5da45a 100644 --- a/routers/dataset/dataset.go +++ b/routers/dataset/dataset.go @@ -1,6 +1,7 @@ package dataset import ( + "errors" "strings" "code.gitea.io/gitea/models" @@ -25,7 +26,7 @@ type ListOptions struct { Page int // start from 1 } -func MyList(ctx *context.Context) { +func List(ctx *context.Context) { ctx.Data["PageIsDatasets"] = true var ( @@ -39,6 +40,7 @@ func MyList(ctx *context.Context) { if page <= 0 { page = 1 } + ctx.Data["SortType"] = ctx.Query("sort") switch ctx.Query("sort") { case "newest": orderBy = models.SearchOrderByNewest @@ -54,16 +56,6 @@ func MyList(ctx *context.Context) { orderBy = models.SearchOrderByAlphabetically case "reversesize": orderBy = models.SearchOrderBySizeReverse - case "size": - orderBy = models.SearchOrderBySize - case "moststars": - orderBy = models.SearchOrderByStarsReverse - case "feweststars": - orderBy = models.SearchOrderByStars - case "mostforks": - orderBy = models.SearchOrderByForksReverse - case "fewestforks": - orderBy = models.SearchOrderByForks default: ctx.Data["SortType"] = "recentupdate" orderBy = models.SearchOrderByRecentUpdated @@ -100,7 +92,6 @@ func MyList(ctx *context.Context) { ctx.Data["datasets"] = datasets ctx.Data["datasetsCount"] = count - log.Debug("[dataset] mylist...\n") ctx.HTML(200, tplDataSet) } @@ -171,7 +162,7 @@ func Show(ctx *context.Context) { return } - isOwner := dataset.UserID == user.ID + isOwner := (ctx.User != nil && dataset.UserID == user.ID) ctx.Data["dataset"] = dataset ctx.Data["IsOwner"] = isOwner @@ -189,6 +180,11 @@ func EditDataset(ctx *context.Context) { ctx.NotFound("GetDataset", err) return } + isOwner := (ctx.User != nil && rel.UserID == ctx.User.ID) + if !isOwner { + ctx.NotFound("403", errors.New("not owner")) + return + } ctx.Data["ID"] = rel.ID ctx.Data["title"] = rel.Title @@ -209,6 +205,11 @@ func EditDatasetPost(ctx *context.Context, form auth.EditDatasetForm) { ctx.ServerError("GetDataset", err) return } + isOwner := (ctx.User != nil && rel.UserID == ctx.User.ID) + if !isOwner { + ctx.NotFound("403", errors.New("not owner")) + return + } ctx.Data["ID"] = rel.ID ctx.Data["title"] = rel.Title ctx.Data["description"] = rel.Description diff --git a/routers/routes/routes.go b/routers/routes/routes.go index 51e14f037..8a42ebae7 100644 --- a/routers/routes/routes.go +++ b/routers/routes/routes.go @@ -1007,7 +1007,7 @@ func RegisterRoutes(m *macaron.Macaron) { // DataSet m.Group("/datasets", func() { - m.Get("", dataset.MyList) + m.Get("", dataset.List) m.Get("/create", dataset.Create) m.Post("/create", bindIgnErr(auth.CreateDatasetForm{}), dataset.CreatePost) m.Post("/delete", dataset.Delete) diff --git a/templates/datasets/show.tmpl b/templates/datasets/show.tmpl index 4740561e1..53d8d6525 100644 --- a/templates/datasets/show.tmpl +++ b/templates/datasets/show.tmpl @@ -32,7 +32,9 @@

{{.dataset.Title}} + {{if .isOwner}} ({{$.i18n.Tr "dataset.edit"}}) + {{end}}

{{.dataset.Description}}