Browse Source

fix bug

V20220110.patch
chenyifan01 3 years ago
parent
commit
8dd288ecb4
6 changed files with 8 additions and 8 deletions
  1. +1
    -1
      integrations/pull_update_test.go
  2. +2
    -2
      modules/repository/fork.go
  3. +1
    -1
      modules/repository/fork_test.go
  4. +1
    -1
      routers/api/v1/repo/fork.go
  5. +1
    -1
      routers/repo/pull.go
  6. +2
    -2
      services/repository/repository.go

+ 1
- 1
integrations/pull_update_test.go View File

@@ -58,7 +58,7 @@ func createOutdatedPR(t *testing.T, actor, forkOrg *models.User) *models.PullReq
assert.NoError(t, err) assert.NoError(t, err)
assert.NotEmpty(t, baseRepo) assert.NotEmpty(t, baseRepo)


headRepo, err := repo_module.ForkRepository(actor, forkOrg, baseRepo, "repo-pr-update", "desc")
headRepo, err := repo_module.ForkRepository(actor, forkOrg, baseRepo, "repo-pr-update", "desc", "")
assert.NoError(t, err) assert.NoError(t, err)
assert.NotEmpty(t, headRepo) assert.NotEmpty(t, headRepo)




+ 2
- 2
modules/repository/fork.go View File

@@ -15,7 +15,7 @@ import (
) )


// ForkRepository forks a repository // ForkRepository forks a repository
func ForkRepository(doer, owner *models.User, oldRepo *models.Repository, name, desc string) (_ *models.Repository, err error) {
func ForkRepository(doer, owner *models.User, oldRepo *models.Repository, name, desc, alias string) (_ *models.Repository, err error) {
forkedRepo, err := oldRepo.GetUserFork(owner.ID) forkedRepo, err := oldRepo.GetUserFork(owner.ID)
if err != nil { if err != nil {
return nil, err return nil, err
@@ -33,7 +33,7 @@ func ForkRepository(doer, owner *models.User, oldRepo *models.Repository, name,
Owner: owner, Owner: owner,
OwnerName: owner.Name, OwnerName: owner.Name,
Name: name, Name: name,
Alias: oldRepo.Alias,
Alias: alias,
LowerName: strings.ToLower(name), LowerName: strings.ToLower(name),
Description: desc, Description: desc,
DefaultBranch: oldRepo.DefaultBranch, DefaultBranch: oldRepo.DefaultBranch,


+ 1
- 1
modules/repository/fork_test.go View File

@@ -18,7 +18,7 @@ func TestForkRepository(t *testing.T) {
user := models.AssertExistsAndLoadBean(t, &models.User{ID: 13}).(*models.User) user := models.AssertExistsAndLoadBean(t, &models.User{ID: 13}).(*models.User)
repo := models.AssertExistsAndLoadBean(t, &models.Repository{ID: 10}).(*models.Repository) repo := models.AssertExistsAndLoadBean(t, &models.Repository{ID: 10}).(*models.Repository)


fork, err := ForkRepository(user, user, repo, "test", "test")
fork, err := ForkRepository(user, user, repo, "test", "test", "test")
assert.Nil(t, fork) assert.Nil(t, fork)
assert.Error(t, err) assert.Error(t, err)
assert.True(t, models.IsErrForkAlreadyExist(err)) assert.True(t, models.IsErrForkAlreadyExist(err))


+ 1
- 1
routers/api/v1/repo/fork.go View File

@@ -118,7 +118,7 @@ func CreateFork(ctx *context.APIContext, form api.CreateForkOption) {
forker = org forker = org
} }


fork, err := repo_service.ForkRepository(ctx.User, forker, repo, repo.Name, repo.Description)
fork, err := repo_service.ForkRepository(ctx.User, forker, repo, repo.Name, repo.Description, repo.Alias)
if err != nil { if err != nil {
ctx.Error(http.StatusInternalServerError, "ForkRepository", err) ctx.Error(http.StatusInternalServerError, "ForkRepository", err)
return return


+ 1
- 1
routers/repo/pull.go View File

@@ -221,7 +221,7 @@ func ForkPost(ctx *context.Context, form auth.CreateRepoForm) {
} }
} }


repo, err := repo_service.ForkRepository(ctx.User, ctxUser, forkRepo, form.RepoName, form.Description)
repo, err := repo_service.ForkRepository(ctx.User, ctxUser, forkRepo, form.RepoName, form.Description, form.Alias)
if err != nil { if err != nil {
ctx.Data["Err_RepoName"] = true ctx.Data["Err_RepoName"] = true
switch { switch {


+ 2
- 2
services/repository/repository.go View File

@@ -31,8 +31,8 @@ func CreateRepository(doer, owner *models.User, opts models.CreateRepoOptions) (
} }


// ForkRepository forks a repository // ForkRepository forks a repository
func ForkRepository(doer, u *models.User, oldRepo *models.Repository, name, desc string) (*models.Repository, error) {
repo, err := repo_module.ForkRepository(doer, u, oldRepo, name, desc)
func ForkRepository(doer, u *models.User, oldRepo *models.Repository, name, desc, alias string) (*models.Repository, error) {
repo, err := repo_module.ForkRepository(doer, u, oldRepo, name, desc, alias)
if err != nil { if err != nil {
if repo != nil { if repo != nil {
if errDelete := models.DeleteRepository(doer, u.ID, repo.ID); errDelete != nil { if errDelete := models.DeleteRepository(doer, u.ID, repo.ID); errDelete != nil {


Loading…
Cancel
Save