From 06be0bab426f7ebd7055fde7a9d2ade3aba4a51f Mon Sep 17 00:00:00 2001
From: chenyifan01 <gitea@fake.local>
Date: Thu, 14 Apr 2022 15:32:07 +0800
Subject: [PATCH] #1852 correct createUnix when it is bigger than starTime

---
 models/cloudbrain.go             | 13 ++++++++++---
 routers/api/v1/repo/modelarts.go |  8 ++++----
 routers/repo/cloudbrain.go       |  4 +++-
 3 files changed, 17 insertions(+), 8 deletions(-)

diff --git a/models/cloudbrain.go b/models/cloudbrain.go
index 98b23b552..0751b3e8a 100755
--- a/models/cloudbrain.go
+++ b/models/cloudbrain.go
@@ -111,7 +111,7 @@ type Cloudbrain struct {
 	SubTaskName          string
 	ContainerID          string
 	ContainerIp          string
-	CreatedUnix          timeutil.TimeStamp `xorm:"INDEX created"`
+	CreatedUnix          timeutil.TimeStamp `xorm:"INDEX"`
 	UpdatedUnix          timeutil.TimeStamp `xorm:"INDEX updated"`
 	Duration             int64              `xorm:"DEFAULT 0"` //运行时长 单位秒
 	TrainJobDuration     string             `xorm:"DEFAULT '00:00:00'"`
@@ -184,6 +184,12 @@ func (task *Cloudbrain) ComputeAndSetDuration() {
 	task.TrainJobDuration = ConvertDurationToStr(d)
 }
 
+func (task *Cloudbrain) CorrectCreateUnix() {
+	if task.StartTime > 0 && task.CreatedUnix > task.StartTime {
+		task.CreatedUnix = task.StartTime
+	}
+}
+
 func (task *Cloudbrain) IsTerminal() bool {
 	status := task.Status
 	return status == string(ModelArtsTrainJobCompleted) || status == string(ModelArtsTrainJobFailed) || status == string(ModelArtsTrainJobKilled) || status == string(ModelArtsStopped) || status == string(JobStopped) || status == string(JobFailed) || status == string(JobSucceeded)
@@ -218,6 +224,7 @@ func ParseAndSetDurationFromCloudBrainOne(result JobResultPayload, task *Cloudbr
 			task.EndTime = timeutil.TimeStamp(result.JobStatus.CompletedTime / 1000)
 		}
 	}
+	task.CorrectCreateUnix()
 	task.ComputeAndSetDuration()
 }
 
@@ -1464,7 +1471,7 @@ func UpdateTrainJobVersion(job *Cloudbrain) error {
 func updateJobTrainVersion(e Engine, job *Cloudbrain) error {
 	var sess *xorm.Session
 	sess = e.Where("job_id = ? AND version_name=?", job.JobID, job.VersionName)
-	_, err := sess.Cols("status", "train_job_duration", "duration", "start_time", "end_time").Update(job)
+	_, err := sess.Cols("status", "train_job_duration", "duration", "start_time", "end_time", "created_unix").Update(job)
 	return err
 }
 
@@ -1553,7 +1560,7 @@ func UpdateInferenceJob(job *Cloudbrain) error {
 func updateInferenceJob(e Engine, job *Cloudbrain) error {
 	var sess *xorm.Session
 	sess = e.Where("job_id = ?", job.JobID)
-	_, err := sess.Cols("status", "train_job_duration", "duration", "start_time", "end_time").Update(job)
+	_, err := sess.Cols("status", "train_job_duration", "duration", "start_time", "end_time", "created_unix").Update(job)
 	return err
 }
 func RestartCloudbrain(old *Cloudbrain, new *Cloudbrain) (err error) {
diff --git a/routers/api/v1/repo/modelarts.go b/routers/api/v1/repo/modelarts.go
index e24ac95fb..9e4edea03 100755
--- a/routers/api/v1/repo/modelarts.go
+++ b/routers/api/v1/repo/modelarts.go
@@ -74,6 +74,7 @@ func GetModelArtsNotebook2(ctx *context.APIContext) {
 	if job.EndTime == 0 && models.IsModelArtsDebugJobTerminal(job.Status) {
 		job.EndTime = timeutil.TimeStampNow()
 	}
+	job.CorrectCreateUnix()
 	job.ComputeAndSetDuration()
 	err = models.UpdateJob(job)
 	if err != nil {
@@ -160,6 +161,7 @@ func GetModelArtsTrainJobVersion(ctx *context.APIContext) {
 		}
 
 		if result.JobStatus.State != string(models.JobWaiting) {
+			models.ParseAndSetDurationFromCloudBrainOne(result, job)
 			err = models.UpdateJob(job)
 			if err != nil {
 				log.Error("UpdateJob failed:", err)
@@ -177,14 +179,12 @@ func GetModelArtsTrainJobVersion(ctx *context.APIContext) {
 		}
 		job.Status = modelarts.TransTrainJobStatus(result.IntStatus)
 		job.Duration = result.Duration / 1000
-		job.TrainJobDuration = result.TrainJobDuration
-
 		job.TrainJobDuration = models.ConvertDurationToStr(job.Duration)
 
 		if job.EndTime == 0 && models.IsTrainJobTerminal(job.Status) && job.StartTime > 0 {
 			job.EndTime = job.StartTime.Add(job.Duration)
 		}
-
+		job.CorrectCreateUnix()
 		err = models.UpdateTrainJobVersion(job)
 		if err != nil {
 			log.Error("UpdateJob failed:", err)
@@ -417,7 +417,7 @@ func GetModelArtsInferenceJob(ctx *context.APIContext) {
 	if job.EndTime == 0 && models.IsTrainJobTerminal(job.Status) && job.StartTime > 0 {
 		job.EndTime = job.StartTime.Add(job.Duration)
 	}
-
+	job.CorrectCreateUnix()
 	err = models.UpdateInferenceJob(job)
 	if err != nil {
 		log.Error("UpdateJob failed:", err)
diff --git a/routers/repo/cloudbrain.go b/routers/repo/cloudbrain.go
index 0d007a27d..26fbe175f 100755
--- a/routers/repo/cloudbrain.go
+++ b/routers/repo/cloudbrain.go
@@ -1156,6 +1156,7 @@ func SyncCloudbrainStatus() {
 					if task.EndTime == 0 && models.IsModelArtsDebugJobTerminal(task.Status) {
 						task.EndTime = timeutil.TimeStampNow()
 					}
+					task.CorrectCreateUnix()
 					task.ComputeAndSetDuration()
 					err = models.UpdateJob(task)
 					if err != nil {
@@ -1182,7 +1183,7 @@ func SyncCloudbrainStatus() {
 					if task.EndTime == 0 && models.IsTrainJobTerminal(task.Status) && task.StartTime > 0 {
 						task.EndTime = task.StartTime.Add(task.Duration)
 					}
-
+					task.CorrectCreateUnix()
 					err = models.UpdateJob(task)
 					if err != nil {
 						log.Error("UpdateJob(%s) failed:%v", task.JobName, err)
@@ -1304,6 +1305,7 @@ func handleNoDurationTask(cloudBrains []*models.Cloudbrain) {
 						task.StartTime = timeutil.TimeStamp(startTime / 1000)
 						task.EndTime = task.StartTime.Add(duration)
 					}
+					task.CorrectCreateUnix()
 					task.ComputeAndSetDuration()
 					err = models.UpdateJob(task)
 					if err != nil {