Browse Source

Use chronological commit order in default squash message (#13661) (#13696)

tags/v1.15.0-dev
Jimmy Praet GitHub 4 years ago
parent
commit
daae08188f
1 changed files with 3 additions and 2 deletions
  1. +3
    -2
      services/pull/pull.go

+ 3
- 2
services/pull/pull.go View File

@@ -556,7 +556,8 @@ func GetCommitMessages(pr *models.PullRequest) string {
authorsMap := map[string]bool{} authorsMap := map[string]bool{}
authors := make([]string, 0, list.Len()) authors := make([]string, 0, list.Len())
stringBuilder := strings.Builder{} stringBuilder := strings.Builder{}
element := list.Front()
// commits list is in reverse chronological order
element := list.Back()
for element != nil { for element != nil {
commit := element.Value.(*git.Commit) commit := element.Value.(*git.Commit)


@@ -581,7 +582,7 @@ func GetCommitMessages(pr *models.PullRequest) string {
authors = append(authors, authorString) authors = append(authors, authorString)
authorsMap[authorString] = true authorsMap[authorString] = true
} }
element = element.Next()
element = element.Prev()
} }


// Consider collecting the remaining authors // Consider collecting the remaining authors


Loading…
Cancel
Save