Browse Source

Always wait for the cmd to finish (#14006)

After cancelling the context we still need to wait for the
command to finish otherwise zombie processes may occur

Fix #13987

Signed-off-by: Andrew Thornton <art27@cantab.net>

Co-authored-by: 6543 <6543@obermui.de>
tags/v1.15.0-dev
zeripath GitHub 4 years ago
parent
commit
dfbf8692bf
1 changed files with 1 additions and 0 deletions
  1. +1
    -0
      modules/git/command.go

+ 1
- 0
modules/git/command.go View File

@@ -153,6 +153,7 @@ func (c *Command) RunInDirTimeoutEnvFullPipelineFunc(env []string, timeout time.
err := fn(ctx, cancel) err := fn(ctx, cancel)
if err != nil { if err != nil {
cancel() cancel()
_ = cmd.Wait()
return err return err
} }
} }


Loading…
Cancel
Save