Browse Source

Fix scrolling to resolved comment anchors (#13343)

* Fix scrolling to resolved comment anchors

As described on discord, when the window.location.hash refers to a
resolved comment then the scroll to functionality does not work.

This PR fixes this.

Signed-off-by: Andrew Thornton <art27@cantab.net>

* Apply suggestions from code review

Co-authored-by: silverwind <me@silverwind.io>

Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
tags/v1.15.0-dev
zeripath GitHub 4 years ago
parent
commit
f36d3bc07c
1 changed files with 16 additions and 0 deletions
  1. +16
    -0
      web_src/js/index.js

+ 16
- 0
web_src/js/index.js View File

@@ -1172,6 +1172,22 @@ async function initRepository() {
}

function initPullRequestReview() {
if (window.location.hash && window.location.hash.startsWith('#issuecomment-')) {
const commentDiv = $(window.location.hash);
if (commentDiv) {
// get the name of the parent id
const groupID = commentDiv.closest('div[id^="code-comments-"]').attr('id');
if (groupID && groupID.startsWith('code-comments-')) {
const id = groupID.substr(14);
$(`#show-outdated-${id}`).addClass('hide');
$(`#code-comments-${id}`).removeClass('hide');
$(`#code-preview-${id}`).removeClass('hide');
$(`#hide-outdated-${id}`).removeClass('hide');
$(window).scrollTop(commentDiv.offset().top);
}
}
}

$('.show-outdated').on('click', function (e) {
e.preventDefault();
const id = $(this).data('comment');


Loading…
Cancel
Save