From 10d1eac2cefe0f98a6466248e06df3c6f4464967 Mon Sep 17 00:00:00 2001 From: Devesh Kumar Date: Wed, 11 Nov 2020 05:35:35 -0600 Subject: [PATCH] coverage improved Former-commit-id: 0e9d0b1605354248d69678f6f5c4f0d83ab25bdf [formerly 80ad54b355bf8ee71d50574d14fcdf55d83a24d6] [formerly ed77ad3dac143699aa401c6f7db41c48d2cb599e [formerly 89e168cebc85231cb30378d86f7480bd875dd1d9]] [formerly cd96e9a82ca2edbdcb0ae7f193cf8d73d3726218 [formerly 27c0b0ba0f0b3fe0c4c558485de4d2ef55b6f4ef] [formerly 1cff7494b641a980ec46a79b81b130118aa44338 [formerly 66da0b5b8e926dcd26d2435675ebe0f52d163937]]] [formerly d2874bdeed4157ee49d984d31a83b9c6306d745b [formerly a3f542ae5c55c4d4f85b8f76106b76b937d66d72] [formerly 490dd6b577e423e6658993cffc7e4c72481a4835 [formerly 78dc05da7d4ece38b1cb1354f41e93826a831d25]] [formerly d63163b90c5fd2bb95952c66fa29620d3c77049a [formerly fbb29349831a9ea4709c67ed12a7f278908a0414] [formerly 5d137ad085482847fb2cbb4174ed3bd8cd8031e1 [formerly cfa75f530406523aacd78a45b8a3cf7e365ee33d]]]] [formerly d4e229b31aba18af7ecdad0fab82fdcfda265f7b [formerly dbc5d51b2561aebdfd3315b7c58ba5d1b683f77e] [formerly ceb3f7847a01002756386a53601b75869941c35f [formerly d366baf521ecbf5fba959c467313543752816e9c]] [formerly b4fbdb3efe9cefa61b1c6ad38fce651e55be8667 [formerly f1f7497ff66151d80fa23efc56a6743ee54a4ec1] [formerly d8f98fd5b15a211d86345d198abf97470b773f14 [formerly f3084edd477d99c39d5b5b3030a38854f488ab20]]] [formerly 499bcf0b0804227c2c1ca9e31fc52b9d5e36585b [formerly a96a3eb6580a22553eee7d97c4bf8bacca6a4002] [formerly 35ac7e98e833deb9ef47ecb30d8daaf6cbe16e69 [formerly ae8098708b5053305604112c5ccbbd3a4688648a]] [formerly 7323e59746b780d366aff904fc4c1f1804bddc28 [formerly bb01e845f856f9ca2098f96c41f0025ebaf2c651] [formerly ee205cbecb2fbb857f48f9822918459741dbde28 [formerly 19eafdf8ce4e4d1f73623c5294dfb5a60e73a324]]]]] [formerly 240565bc56ed6ab91fb7dd60285cde7a2cca23d3 [formerly e6028092f6f3f093b9bfa1d85926d9423957679d] [formerly 1bd49fd4e44fee53151b5478011d1513b8ccb3cb [formerly c9899ae52c4cbd84ec79478a64023dfd7eee5428]] [formerly 827818231874c9933be914702e3edcceb2d9d8e5 [formerly b2fe4e9a6507640926d71a970349f84676c0c988] [formerly 18f37ce94bcf12ae78ef097722f1019403c8f784 [formerly bac395a8a6c81f9f2c4b65621fdc176ba9017b76]]] [formerly 23a407f069d91bb269117b62711deee7013a5521 [formerly 95218a7e3b498acc3b493232e8175ceef3d61ef6] [formerly 77afa5d2485507979d51c2f050dd7046bdc20365 [formerly 5ecccbd07dd7f0738c2bc624bfdc6dc655b7f9f0]] [formerly 70e43360de7d9aac9643d7f229175eadeda3f2bc [formerly 83b19b0c0bf83834f5ae2625787c568e414eaf5d] [formerly a536f4e4b94a39ce45d4e80410b181575a70d9e4 [formerly b175259e293d4e5b5ff373876e3fa1368b961d90]]]] [formerly 7552ded85f7d3a85c9c89642f9a3eee9c79567d9 [formerly 34633335c3699a5f7aeeea6b064a4f1bc582d509] [formerly 3e52bdcfdb5f9f86f4129b64cadc76a7bacdd9dc [formerly fafc16e78864b94e8f2a474a8ff64c77ea01ba7f]] [formerly 101ff609046922094e85a4ff10e648e88bb05e61 [formerly 62005dbb12fee3ca1a6e773bcd0cff21cfa8f730] [formerly 5d40cc602dc1f7993334a97b860c6bdad663b48e [formerly 85a1d0e3b0ea9b7063f921d620c9cd43bbaaba60]]] [formerly 3f37814f119732ce99b8c00379d84f923a2ca0cc [formerly b6c59f509204bd642dc6c1cb02ecac78c3a76afd] [formerly 9add2b76209b8482a6d697ac061859f6ecb9f4b4 [formerly 39d23d935e884866b39a3883ebc7538e2d50b43d]] [formerly aad5ffe5c54c651de33ea749a46565247a81d9f6 [formerly f8fc74ef13f7b2b9eb1e6f6e4f9080ed7e148349] [formerly 9c12a1955b6248efc1b95633ccc1aa680f5ffd47 [formerly b273736482b90ea64c31b4f5af04f5018c1368e0]]]]]] Former-commit-id: 1f8a5b11daa67ea3cfdfac564b6203baf1a5d430 [formerly eb567c3207c62175607ed278f593265506e4069f] [formerly 8b71d0725371207add656a32d4808e97774cb3f2 [formerly 75d2f0a81958446e035c1ea27afa534e04babc65]] [formerly 620c48fb4ff97b03346517ac50ed527213683bbe [formerly 1e9610c911344474c1d96addc1ad20551c0270e7] [formerly fd39a8f0480a1b05126b92582013abd143ea85d9 [formerly 2aca9eac2073212fec390792256f605368e34b32]]] [formerly ee95f3b9efc725799c2fc49f2ecc14e10c198761 [formerly 425eb7bd922a559637b2c36bf316eb9f60a56c3c] [formerly aa3940c44612c8f6b293f454a58062c2f1a3fa1a [formerly 19c0b16525be54f9c10214fa4171abfcc82120d7]] [formerly 18da08ab19ba08068850c158b8defd540ee89834 [formerly 85baa95d49a09e0ea577b8af5567b38bccae2ea4] [formerly 66b6c6192825c3113efc00cded79585ac4c37aa8 [formerly a59f50b56e33695f060d0a98217d1b7d93c70815]]]] [formerly 3d1b071340277aabeebb69a0c16a2dbd9b52b3a9 [formerly 3ae79ad5cad2e72b4b50f183acab3c151c8bbc07] [formerly d8fe04ad477767ebaf669b5a8803dc5fd1087fd0 [formerly 27b5606255739a93f54f76900eea645d6f0a7eb2]] [formerly d5e517c9ed17bdd8f734060ca57c9e42455d15c3 [formerly cce28c079f1f70971d6ae4dc90fafbfc6f56fb61] [formerly 8438a2ec9965490e844ca81207ef9090e1e215d2 [formerly af383aac805786e1fbabae4fad79f6ea0e7e977e]]] [formerly 7172f0198f90f3bea8f36e21b9622d9d008354c7 [formerly fbbf8fb034047e04f0a552be54b131c101966005] [formerly 0d10343c884b24da5f394c558c022f9cc94b73ee [formerly 44dfb749b6a1c3345f43c4363dfb7ee6bb75534d]] [formerly 1ad4f9498e9f69a6198a3894d1787382814e0f04 [formerly 90261c5899251881288ed26d0d4783f99eb57102] [formerly 9c12a1955b6248efc1b95633ccc1aa680f5ffd47]]]] Former-commit-id: 5411b622de6097996beb3348fab4f7895a200a9c [formerly 056c327438d82243cdf6e307ca5f10976be53ee7] [formerly b8d5dde676514d41ad910de6113c7ce19ed17593 [formerly 80efc67b8c29773feafcaa8e6e648d8baab02565]] [formerly e23f40d2df66641a9e6fdc9ea8fc36e5741e9a5c [formerly 34ebf2bab3c3b6116e1f5c0eb618c792a9169688] [formerly e94f6e3f9061412202cfc275373c59b2e762ebe0 [formerly 5ec9494b6c378460656d6c4e64541f2cac7386b2]]] [formerly 18eeb4d19b911dbadae1da3a85a270fd184e1108 [formerly a892cb44dac3c7139a1b41d7ebc37e13dcec76a9] [formerly 3aa6643f918cdc6d36db0d64fdc6cc5b92b329fa [formerly 4d1fc5971da1f61da994d371884827c1aec06743]] [formerly c3697fb848817272bdfe5ffcf03e17746000c4df [formerly 7bbc8f0541fd748503275c29488bb165d9ccb8b2] [formerly a461d5bbe1886ea0109677c9de47c54e1a6bd532 [formerly 42292d0671d933e7ea487033ecbb71ade928fa82]]]] Former-commit-id: c0a0cae4e0a14f5251aa55c57dcd2f0d25779e78 [formerly e6c990fa3dd0b86157a4bf8627bc875d9541f231] [formerly 84cb7116b58d6b5fcb42f46539e0f0ae7ca8b4fe [formerly daac5c2bb4dd4258a8cbd8ea618405c3b7936343]] [formerly 4a5c20cd47762abfe750fc30a81eb70e32dc0508 [formerly dd12d210e120a35dc21353c4f9dc50605e7f4210] [formerly 37f25b659dfedf94f15346f7786dbe09a4aab3fe [formerly f692d782503232f0bd11349b4247424cd7223eb9]]] Former-commit-id: d6492e2336c73ac0b0660cf482d4dc668031115b [formerly 14cab6d6d469fd2eb4d5293a9ec10953ef3bf817] [formerly 7b20ea7a9ab81f9e62761670cd3c68b795093c21 [formerly e860e61936d234fb32ab0e4aa3980647fcaadca1]] Former-commit-id: 33119ccf2b3790c5f0bfaa7d90725e8bce5b19f3 [formerly 5a1211c7d92ea48b3ec8ea0a54d3c827b66fd9be] Former-commit-id: fab4841b85a4d464364960631bdbaf37f185f435 --- tods/data_processing/SKImputer.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tods/data_processing/SKImputer.py b/tods/data_processing/SKImputer.py index 18f7612..4e6c3b0 100644 --- a/tods/data_processing/SKImputer.py +++ b/tods/data_processing/SKImputer.py @@ -194,7 +194,7 @@ class SKImputerPrimitive(UnsupervisedLearnerPrimitiveBase[Inputs, Outputs, Param self._clf.fit(self._training_inputs) self._fitted = True else: - if self.hyperparams['error_on_no_input']: + if self.hyperparams['error_on_no_input']: # pragma: no cover raise RuntimeError("No input columns were selected") self.logger.warn("No input columns were selected") return CallResult(None) @@ -215,7 +215,7 @@ class SKImputerPrimitive(UnsupervisedLearnerPrimitiveBase[Inputs, Outputs, Param output.columns = [inputs.columns[idx] for idx in range(len(inputs.columns)) if idx in self._training_indices] output = [output] else: - if self.hyperparams['error_on_no_input']: + if self.hyperparams['error_on_no_input']: # pragma: no cover raise RuntimeError("No input columns were selected") self.logger.warn("No input columns were selected") _, _, dropped_cols = self._get_columns_to_fit(inputs, self.hyperparams) @@ -308,7 +308,7 @@ class SKImputerPrimitive(UnsupervisedLearnerPrimitiveBase[Inputs, Outputs, Param return columns_to_remove @classmethod - def _can_produce_column(cls, inputs_metadata: metadata_base.DataMetadata, column_index: int, hyperparams: Hyperparams) -> bool: + def _can_produce_column(cls, inputs_metadata: metadata_base.DataMetadata, column_index: int, hyperparams: Hyperparams) -> bool: # pragma: no cover column_metadata = inputs_metadata.query((metadata_base.ALL_ELEMENTS, column_index)) accepted_structural_types = (int, float, numpy.integer, numpy.float64) @@ -330,7 +330,7 @@ class SKImputerPrimitive(UnsupervisedLearnerPrimitiveBase[Inputs, Outputs, Param @classmethod - def _get_target_columns_metadata(cls, outputs_metadata: metadata_base.DataMetadata, hyperparams) -> List[OrderedDict]: + def _get_target_columns_metadata(cls, outputs_metadata: metadata_base.DataMetadata, hyperparams) -> List[OrderedDict]: # pragma: no cover outputs_length = outputs_metadata.query((metadata_base.ALL_ELEMENTS,))['dimension']['length'] target_columns_metadata: List[OrderedDict] = []