 test: Split Unit and Integration tests into separate projects (#1290)
* Squashed commit of test rewrite changes
fix missing priority speaker flag
rewrite the TestChannelPermissionModify test
add test for GuildPermission modify
separate unit and integration tests, start writing channel and guild permission tests
copy over the color tests
copy over the emote tests
copy the token utils tests
make the mocked entities sealed classes
copy the TypeReaderTests class
properly dispose the CommandService in the TypeReaderTests
start writing tests for EmbedBuilder and related classes
test that properties throw ArgumentException when invalid
add tests for the embed length property
add withFooter tests
finish adding tests to EmbedBuilder
fix bug in value validation of EmbedFieldBuilder
hey, these tests actually found a bug!
add tests for the MentionUtils class
add tests for the Format util class
remove all of the old tests
add analyzer tests (copied from old tests)
add tests for the SnowflakeUtils class
add integration tests
these get around the issue of state persisting between tests by creating and deleting a guild for each set of tests. these shouldn't be run excessively because of the rate limits, but should be fine every now and then
remove unnecessary launchSettings.json
update outdated string
don't create a new guild each time, as that can result in errors
this can happen if a bot creates too many guilds without properly deleting them
add some tests that show that guild can be modified
await async assert
add more measures that created channels are deleted when done
remove "Test" prefix from test method names
I think that this prefix when already displayed under a class with a suffix of "Tests" is redundant
Remove mention of old test project
fix an issue from forgetting to await Assert.ThrowsAsync
explicitly disable parallelization on integration tests
add test for GuildPermission modify
separate unit and integration tests, start writing channel and guild permission tests
copy over the color tests
copy over the emote tests
make the mocked entities sealed classes
properly dispose the CommandService in the TypeReaderTests
fix bug in value validation of EmbedFieldBuilder
hey, these tests actually found a bug!
add tests for the MentionUtils class
add tests for the Format util class
remove all of the old tests
add analyzer tests (copied from old tests)
add tests for the SnowflakeUtils class
add integration tests
these get around the issue of state persisting between tests by creating and deleting a guild for each set of tests. these shouldn't be run excessively because of the rate limits, but should be fine every now and then
remove unnecessary launchSettings.json
update outdated string
don't create a new guild each time, as that can result in errors
this can happen if a bot creates too many guilds without properly deleting them
add more measures that created channels are deleted when done
remove "Test" prefix from test method names
I think that this prefix when already displayed under a class with a suffix of "Tests" is redundant
Remove mention of old test project
fix an issue from forgetting to await Assert.ThrowsAsync
explicitly disable parallelization on integration tests
update the azure CI build script
separate execution of test projects so that if one fails the other will not pass
one of the unit tests failed, but the analzyer tests passed
fix test that would break in different timezones
enable the integration tests (only on dev branch)
* Squashed commit of test rewrite changes
fix missing priority speaker flag
rewrite the TestChannelPermissionModify test
add test for GuildPermission modify
separate unit and integration tests, start writing channel and guild permission tests
copy over the color tests
copy over the emote tests
copy the token utils tests
make the mocked entities sealed classes
copy the TypeReaderTests class
properly dispose the CommandService in the TypeReaderTests
start writing tests for EmbedBuilder and related classes
test that properties throw ArgumentException when invalid
add tests for the embed length property
add withFooter tests
finish adding tests to EmbedBuilder
fix bug in value validation of EmbedFieldBuilder
hey, these tests actually found a bug!
add tests for the MentionUtils class
add tests for the Format util class
remove all of the old tests
add analyzer tests (copied from old tests)
add tests for the SnowflakeUtils class
add integration tests
these get around the issue of state persisting between tests by creating and deleting a guild for each set of tests. these shouldn't be run excessively because of the rate limits, but should be fine every now and then
remove unnecessary launchSettings.json
update outdated string
don't create a new guild each time, as that can result in errors
this can happen if a bot creates too many guilds without properly deleting them
add some tests that show that guild can be modified
await async assert
add more measures that created channels are deleted when done
remove "Test" prefix from test method names
I think that this prefix when already displayed under a class with a suffix of "Tests" is redundant
Remove mention of old test project
fix an issue from forgetting to await Assert.ThrowsAsync
explicitly disable parallelization on integration tests
add test for GuildPermission modify
separate unit and integration tests, start writing channel and guild permission tests
copy over the color tests
copy over the emote tests
make the mocked entities sealed classes
properly dispose the CommandService in the TypeReaderTests
fix bug in value validation of EmbedFieldBuilder
hey, these tests actually found a bug!
add tests for the MentionUtils class
add tests for the Format util class
remove all of the old tests
add analyzer tests (copied from old tests)
add tests for the SnowflakeUtils class
add integration tests
these get around the issue of state persisting between tests by creating and deleting a guild for each set of tests. these shouldn't be run excessively because of the rate limits, but should be fine every now and then
remove unnecessary launchSettings.json
update outdated string
don't create a new guild each time, as that can result in errors
this can happen if a bot creates too many guilds without properly deleting them
add more measures that created channels are deleted when done
remove "Test" prefix from test method names
I think that this prefix when already displayed under a class with a suffix of "Tests" is redundant
Remove mention of old test project
fix an issue from forgetting to await Assert.ThrowsAsync
explicitly disable parallelization on integration tests
update the azure CI build script
separate execution of test projects so that if one fails the other will not pass
one of the unit tests failed, but the analzyer tests passed
fix test that would break in different timezones
enable the integration tests (only on dev branch)
* Update mocked channels for changed SendFileAsync signature
* comment out the integration tests from the build script
no bot token is provided to this script, and use of integration tests in CI is questionable here
* force rebuild because Azure linux build broke
6 years ago |
123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467 |
- using System;
- using System.Collections.Generic;
- using System.Text;
- using Xunit;
-
- namespace Discord
- {
- /// <summary>
- /// Tests the <see cref="Discord.EmbedBuilder"/> class.
- /// </summary>
- public class EmbedBuilderTests
- {
- private const string name = "chrisj";
- private const string icon = "https://meowpuffygottem.fun/blob.png";
- private const string url = "https://meowpuffygottem.fun/";
-
- /// <summary>
- /// Tests the behavior of <see cref="EmbedBuilder.WithAuthor(string, string, string)"/>.
- /// </summary>
- [Fact]
- public void WithAuthor_Strings()
- {
- var builder = new EmbedBuilder();
- // null by default
- Assert.Null(builder.Author);
-
- builder = new EmbedBuilder()
- .WithAuthor(name, icon, url);
-
- Assert.NotNull(builder.Author);
- Assert.Equal(name, builder.Author.Name);
- Assert.Equal(icon, builder.Author.IconUrl);
- Assert.Equal(url, builder.Author.Url);
- }
-
- /// <summary>
- /// Tests the behavior of <see cref="EmbedBuilder.WithAuthor(EmbedAuthorBuilder)"/>
- /// </summary>
- [Fact]
- public void WithAuthor_AuthorBuilder()
- {
- var author = new EmbedAuthorBuilder()
- .WithIconUrl(icon)
- .WithName(name)
- .WithUrl(url);
- var builder = new EmbedBuilder()
- .WithAuthor(author);
- Assert.NotNull(builder.Author);
- Assert.Equal(name, builder.Author.Name);
- Assert.Equal(icon, builder.Author.IconUrl);
- Assert.Equal(url, builder.Author.Url);
- }
-
- /// <summary>
- /// Tests the behavior of <see cref="EmbedBuilder.WithAuthor(Action{EmbedAuthorBuilder})"/>
- /// </summary>
- [Fact]
- public void WithAuthor_ActionAuthorBuilder()
- {
- var builder = new EmbedBuilder()
- .WithAuthor((author) =>
- author.WithIconUrl(icon)
- .WithName(name)
- .WithUrl(url));
- Assert.NotNull(builder.Author);
- Assert.Equal(name, builder.Author.Name);
- Assert.Equal(icon, builder.Author.IconUrl);
- Assert.Equal(url, builder.Author.Url);
- }
-
- /// <summary>
- /// Tests the behavior of <see cref="EmbedAuthorBuilder"/>.
- /// </summary>
- [Fact]
- public void EmbedAuthorBuilder()
- {
- var builder = new EmbedAuthorBuilder()
- .WithIconUrl(icon)
- .WithName(name)
- .WithUrl(url);
- Assert.Equal(icon, builder.IconUrl);
- Assert.Equal(name, builder.Name);
- Assert.Equal(url, builder.Url);
- }
-
- /// <summary>
- /// Tests that invalid titles throw an <see cref="ArgumentException"/>.
- /// </summary>
- /// <param name="title">The embed title to set.</param>
- [Theory]
- // 257 chars
- [InlineData("jVyLChmA7aBZozXQuZ3VDEcwW6zOq0nteOVYBZi31ny73rpXfSSBXR4Jw6FiplDKQseKskwRMuBZkUewrewqAbkBZpslHirvC5nEzRySoDIdTRnkVvTXZUXg75l3bQCjuuHxDd6DfrY8ihd6yZX1Y0XFeg239YBcYV4TpL9uQ8H3HFYxrWhLlG2PRVjUmiglP5iXkawszNwMVm1SZ5LZT4jkMZHxFegVi7170d16iaPWOovu50aDDHy087XBtLKVa")]
- // 257 chars of whitespace
- [InlineData(" ")]
- public void Title_Invalid(string title)
- {
- Assert.Throws<ArgumentException>(() =>
- {
- var builder = new EmbedBuilder();
- builder.Title = title;
- });
- Assert.Throws<ArgumentException>(() =>
- {
- new EmbedBuilder().WithTitle(title);
- });
- }
-
- /// <summary>
- /// Tests that valid titles do not throw any exceptions.
- /// </summary>
- /// <param name="title">The embed title to set.</param>
- [Theory]
- // 256 chars
- [InlineData("jVyLChmA7aBZozXQuZ3VDEcwW6zOq0nteOVYBZi31ny73rpXfSSBXR4Jw6FiplDKQseKskwRMuBZkUewrewqAbkBZpslHirvC5nEzRySoDIdTRnkVvTXZUXg75l3bQCjuuHxDd6DfrY8ihd6yZX1Y0XFeg239YBcYV4TpL9uQ8H3HFYxrWhLlG2PRVjUmiglP5iXkawszNwMVm1SZ5LZT4jkMZHxFegVi7170d16iaPWOovu50aDDHy087XBtLKV")]
- public void Tile_Valid(string title)
- {
- var builder = new EmbedBuilder();
- builder.Title = title;
- new EmbedBuilder().WithTitle(title);
- }
-
- /// <summary>
- /// Tests that invalid descriptions throw an <see cref="ArgumentException"/>.
- /// </summary>
- [Fact]
- public void Description_Invalid()
- {
- IEnumerable<string> GetInvalid()
- {
- yield return new string('a', 2049);
- }
- foreach (var description in GetInvalid())
- {
- Assert.Throws<ArgumentException>(() => new EmbedBuilder().WithDescription(description));
- Assert.Throws<ArgumentException>(() =>
- {
- var b = new EmbedBuilder();
- b.Description = description;
- });
- }
- }
-
- /// <summary>
- /// Tests that valid descriptions do not throw any exceptions.
- /// </summary>
- [Fact]
- public void Description_Valid()
- {
- IEnumerable<string> GetValid()
- {
- yield return string.Empty;
- yield return null;
- yield return new string('a', 2048);
- }
- foreach (var description in GetValid())
- {
- var b = new EmbedBuilder().WithDescription(description);
- Assert.Equal(description, b.Description);
-
- b = new EmbedBuilder();
- b.Description = description;
- Assert.Equal(description, b.Description);
- }
- }
-
- /// <summary>
- /// Tests that valid urls do not throw any exceptions.
- /// </summary>
- /// <param name="url">The url to set.</param>
- [Theory]
- [InlineData(null)]
- [InlineData("")]
- [InlineData("https://docs.stillu.cc")]
- public void Url_Valid(string url)
- {
- // does not throw an exception
- var result = new EmbedBuilder()
- .WithUrl(url)
- .WithImageUrl(url)
- .WithThumbnailUrl(url);
- Assert.Equal(result.Url, url);
- Assert.Equal(result.ImageUrl, url);
- Assert.Equal(result.ThumbnailUrl, url);
-
- result = new EmbedBuilder();
- result.Url = url;
- result.ImageUrl = url;
- result.ThumbnailUrl = url;
- Assert.Equal(result.Url, url);
- Assert.Equal(result.ImageUrl, url);
- Assert.Equal(result.ThumbnailUrl, url);
- }
-
- /// <summary>
- /// Tests that invalid urls throw an <see cref="ArgumentException"/>.
- /// </summary>
- /// <param name="url">The url to set.</param>
- [Theory]
- [InlineData(" ")]
- [InlineData("not a url")]
- public void Url_Invalid(string url)
- {
- Assert.Throws<ArgumentException>(()
- => new EmbedBuilder()
- .WithUrl(url));
- Assert.Throws<ArgumentException>(()
- => new EmbedBuilder()
- .WithImageUrl(url));
- Assert.Throws<ArgumentException>(()
- => new EmbedBuilder()
- .WithThumbnailUrl(url));
-
- Assert.Throws<ArgumentException>(() =>
- {
- var b = new EmbedBuilder();
- b.Url = url;
- });
- Assert.Throws<ArgumentException>(() =>
- {
- var b = new EmbedBuilder();
- b.ImageUrl = url;
- });
- Assert.Throws<ArgumentException>(() =>
- {
- var b = new EmbedBuilder();
- b.ThumbnailUrl = url;
- });
- }
-
- /// <summary>
- /// Tests the value of the <see cref="EmbedBuilder.Length"/> property when there are no fields set.
- /// </summary>
- [Fact]
- public void Length_Empty()
- {
- var empty = new EmbedBuilder();
- Assert.Equal(0, empty.Length);
- }
-
- /// <summary>
- /// Tests the value of the <see cref="EmbedBuilder.Length"/> property when all fields are set.
- /// </summary>
- [Fact]
- public void Length()
- {
- var e = new EmbedBuilder()
- .WithAuthor(name, icon, url)
- .WithColor(Color.Blue)
- .WithDescription("This is the test description.")
- .WithFooter("This is the footer", url)
- .WithImageUrl(url)
- .WithThumbnailUrl(url)
- .WithTimestamp(DateTime.MinValue)
- .WithTitle("This is the title")
- .WithUrl(url)
- .AddField("Field 1", "Inline", true)
- .AddField("Field 2", "Not Inline", false);
- Assert.Equal(100, e.Length);
- }
-
- /// <summary>
- /// Tests the behavior of <see cref="EmbedBuilder.WithCurrentTimestamp"/>.
- /// </summary>
- [Fact]
- public void WithCurrentTimestamp()
- {
- var e = new EmbedBuilder()
- .WithCurrentTimestamp();
- // ensure within a second of accuracy
- Assert.Equal(DateTime.UtcNow, e.Timestamp.Value.UtcDateTime, TimeSpan.FromSeconds(1));
- }
-
- /// <summary>
- /// Tests the behavior of <see cref="EmbedBuilder.WithColor(Color)"/>.
- /// </summary>
- [Fact]
- public void WithColor()
- {
- // use WithColor
- var e = new EmbedBuilder().WithColor(Color.Red);
- Assert.Equal(Color.Red.RawValue, e.Color.Value.RawValue);
- }
-
- /// <summary>
- /// Tests the behavior of <see cref="EmbedBuilder.WithFooter(Action{EmbedFooterBuilder})"/>
- /// </summary>
- [Fact]
- public void WithFooter_ActionFooterBuilder()
- {
- var e = new EmbedBuilder()
- .WithFooter(x =>
- {
- x.IconUrl = url;
- x.Text = name;
- });
- Assert.Equal(url, e.Footer.IconUrl);
- Assert.Equal(name, e.Footer.Text);
- }
-
- /// <summary>
- /// Tests the behavior of <see cref="EmbedBuilder.WithFooter(EmbedFooterBuilder)"/>
- /// </summary>
- [Fact]
- public void WithFooter_FooterBuilder()
- {
- var footer = new EmbedFooterBuilder()
- {
- IconUrl = url,
- Text = name
- };
- var e = new EmbedBuilder()
- .WithFooter(footer);
- Assert.Equal(url, e.Footer.IconUrl);
- Assert.Equal(name, e.Footer.Text);
- // use the property
- e = new EmbedBuilder();
- e.Footer = footer;
- Assert.Equal(url, e.Footer.IconUrl);
- Assert.Equal(name, e.Footer.Text);
- }
-
- /// <summary>
- /// Tests the behavior of <see cref="EmbedBuilder.WithFooter(string, string)"/>
- /// </summary>
- [Fact]
- public void WithFooter_Strings()
- {
- var e = new EmbedBuilder()
- .WithFooter(name, url);
- Assert.Equal(url, e.Footer.IconUrl);
- Assert.Equal(name, e.Footer.Text);
- }
-
- /// <summary>
- /// Tests the behavior of <see cref="EmbedFooterBuilder"/>.
- /// </summary>
- [Fact]
- public void EmbedFooterBuilder()
- {
- var footer = new EmbedFooterBuilder()
- .WithIconUrl(url)
- .WithText(name);
- Assert.Equal(url, footer.IconUrl);
- Assert.Equal(name, footer.Text);
- }
- /// <summary>
- /// Tests that invalid URLs throw an <see cref="ArgumentException"/>.
- /// </summary>
- [Fact]
- public void EmbedFooterBuilder_InvalidURL()
- {
- IEnumerable<string> InvalidUrls()
- {
- yield return "not a url";
- }
- foreach (var url in InvalidUrls())
- {
- Assert.Throws<ArgumentException>(() =>
- {
- new EmbedFooterBuilder().WithIconUrl(url);
- });
- }
- }
- /// <summary>
- /// Tests that invalid text throws an <see cref="ArgumentException"/>.
- /// </summary>
- [Fact]
- public void EmbedFooterBuilder_InvalidText()
- {
- Assert.Throws<ArgumentException>(() =>
- {
- new EmbedFooterBuilder().WithText(new string('a', 2049));
- });
- }
- [Fact]
- public void AddField_Strings()
- {
- var e = new EmbedBuilder()
- .AddField("name", "value", true);
- Assert.Equal("name", e.Fields[0].Name);
- Assert.Equal("value", e.Fields[0].Value);
- Assert.True(e.Fields[0].IsInline);
- }
- [Fact]
- public void AddField_EmbedFieldBuilder()
- {
- var field = new EmbedFieldBuilder()
- .WithIsInline(true)
- .WithValue("value")
- .WithName("name");
- var e = new EmbedBuilder()
- .AddField(field);
- Assert.Equal("name", e.Fields[0].Name);
- Assert.Equal("value", e.Fields[0].Value);
- Assert.True(e.Fields[0].IsInline);
- }
- [Fact]
- public void AddField_ActionEmbedFieldBuilder()
- {
- var e = new EmbedBuilder()
- .AddField(x => x
- .WithName("name")
- .WithValue("value")
- .WithIsInline(true));
- Assert.Equal("name", e.Fields[0].Name);
- Assert.Equal("value", e.Fields[0].Value);
- Assert.True(e.Fields[0].IsInline);
- }
- [Fact]
- public void AddField_TooManyFields()
- {
- var e = new EmbedBuilder();
- for (var i = 0; i < 25; i++)
- {
- e = e.AddField("name", "value", false);
- }
- Assert.Throws<ArgumentException>(() =>
- {
- e = e.AddField("name", "value", false);
- });
- }
- [Fact]
- public void EmbedFieldBuilder()
- {
- var e = new EmbedFieldBuilder()
- .WithIsInline(true)
- .WithName("name")
- .WithValue("value");
- Assert.Equal("name", e.Name);
- Assert.Equal("value", e.Value);
- Assert.True(e.IsInline);
- // use the properties
- e = new EmbedFieldBuilder();
- e.IsInline = true;
- e.Name = "name";
- e.Value = "value";
- Assert.Equal("name", e.Name);
- Assert.Equal("value", e.Value);
- Assert.True(e.IsInline);
- }
- [Theory]
- [InlineData("")]
- [InlineData(" ")]
- [InlineData(null)]
- // 257 chars
- [InlineData("jVyLChmA7aBZozXQuZ3VDEcwW6zOq0nteOVYBZi31ny73rpXfSSBXR4Jw6FiplDKQseKskwRMuBZkUewrewqAbkBZpslHirvC5nEzRySoDIdTRnkVvTXZUXg75l3bQCjuuHxDd6DfrY8ihd6yZX1Y0XFeg239YBcYV4TpL9uQ8H3HFYxrWhLlG2PRVjUmiglP5iXkawszNwMVm1SZ5LZT4jkMZHxFegVi7170d16iaPWOovu50aDDHy087XBtLKVa")]
- // 257 chars of whitespace
- [InlineData(" ")]
- public void EmbedFieldBuilder_InvalidName(string name)
- {
- Assert.Throws<ArgumentException>(() => new EmbedFieldBuilder().WithName(name));
- }
- [Fact]
- public void EmbedFieldBuilder_InvalidValue()
- {
- IEnumerable<string> GetInvalidValue()
- {
- yield return null;
- yield return string.Empty;
- yield return " ";
- yield return new string('a', 1025);
- };
- foreach (var v in GetInvalidValue())
- Assert.Throws<ArgumentException>(() => new EmbedFieldBuilder().WithValue(v));
- }
- }
- }
|