From dcd9cdd13ee0bd4d337e07d610dd612b6473ff6b Mon Sep 17 00:00:00 2001 From: Christopher Felegy Date: Sat, 7 Sep 2019 22:19:26 +0000 Subject: [PATCH] lint: rename IsStream to IsStreaming While it might be more proper to refer to a voice state as composing a stream (i.e., the IVoiceState is a Stream), this property is ported up most often to actual user entities. It makes more sense to communicate that the user is streaming, rather than stating that the user itself is a stream. This is also more gramatically consistent with the other voice state properties (e.g., IsMuted). Movement from noun-form to participle-form remains inline with the past-participle form used on the other properties. --- src/Discord.Net.Core/Entities/Users/IVoiceState.cs | 2 +- src/Discord.Net.Rest/Entities/Users/RestGroupUser.cs | 2 +- src/Discord.Net.Rest/Entities/Users/RestGuildUser.cs | 2 +- src/Discord.Net.Rest/Entities/Users/RestWebhookUser.cs | 2 +- src/Discord.Net.WebSocket/Entities/Users/SocketGroupUser.cs | 2 +- src/Discord.Net.WebSocket/Entities/Users/SocketGuildUser.cs | 2 +- src/Discord.Net.WebSocket/Entities/Users/SocketVoiceState.cs | 2 +- src/Discord.Net.WebSocket/Entities/Users/SocketWebhookUser.cs | 2 +- 8 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/Discord.Net.Core/Entities/Users/IVoiceState.cs b/src/Discord.Net.Core/Entities/Users/IVoiceState.cs index ae5f0264c..a9b347003 100644 --- a/src/Discord.Net.Core/Entities/Users/IVoiceState.cs +++ b/src/Discord.Net.Core/Entities/Users/IVoiceState.cs @@ -61,6 +61,6 @@ namespace Discord /// /// true if the user is streaming; otherwise false. /// - bool IsStream { get; } + bool IsStreaming { get; } } } diff --git a/src/Discord.Net.Rest/Entities/Users/RestGroupUser.cs b/src/Discord.Net.Rest/Entities/Users/RestGroupUser.cs index 5be1dc892..55e9843eb 100644 --- a/src/Discord.Net.Rest/Entities/Users/RestGroupUser.cs +++ b/src/Discord.Net.Rest/Entities/Users/RestGroupUser.cs @@ -36,6 +36,6 @@ namespace Discord.Rest /// string IVoiceState.VoiceSessionId => null; /// - bool IVoiceState.IsStream => false; + bool IVoiceState.IsStreaming => false; } } diff --git a/src/Discord.Net.Rest/Entities/Users/RestGuildUser.cs b/src/Discord.Net.Rest/Entities/Users/RestGuildUser.cs index ec329cca5..d6a8c2eda 100644 --- a/src/Discord.Net.Rest/Entities/Users/RestGuildUser.cs +++ b/src/Discord.Net.Rest/Entities/Users/RestGuildUser.cs @@ -152,6 +152,6 @@ namespace Discord.Rest /// string IVoiceState.VoiceSessionId => null; /// - bool IVoiceState.IsStream => false; + bool IVoiceState.IsStreaming => false; } } diff --git a/src/Discord.Net.Rest/Entities/Users/RestWebhookUser.cs b/src/Discord.Net.Rest/Entities/Users/RestWebhookUser.cs index b558ff89a..8462cb8d4 100644 --- a/src/Discord.Net.Rest/Entities/Users/RestWebhookUser.cs +++ b/src/Discord.Net.Rest/Entities/Users/RestWebhookUser.cs @@ -96,6 +96,6 @@ namespace Discord.Rest /// string IVoiceState.VoiceSessionId => null; /// - bool IVoiceState.IsStream => false; + bool IVoiceState.IsStreaming => false; } } diff --git a/src/Discord.Net.WebSocket/Entities/Users/SocketGroupUser.cs b/src/Discord.Net.WebSocket/Entities/Users/SocketGroupUser.cs index b8e05aa0c..676c0a86c 100644 --- a/src/Discord.Net.WebSocket/Entities/Users/SocketGroupUser.cs +++ b/src/Discord.Net.WebSocket/Entities/Users/SocketGroupUser.cs @@ -62,6 +62,6 @@ namespace Discord.WebSocket /// string IVoiceState.VoiceSessionId => null; /// - bool IVoiceState.IsStream => false; + bool IVoiceState.IsStreaming => false; } } diff --git a/src/Discord.Net.WebSocket/Entities/Users/SocketGuildUser.cs b/src/Discord.Net.WebSocket/Entities/Users/SocketGuildUser.cs index fe2d4a3cf..e5dbfa01d 100644 --- a/src/Discord.Net.WebSocket/Entities/Users/SocketGuildUser.cs +++ b/src/Discord.Net.WebSocket/Entities/Users/SocketGuildUser.cs @@ -55,7 +55,7 @@ namespace Discord.WebSocket /// public bool IsMuted => VoiceState?.IsMuted ?? false; /// - public bool IsStream => VoiceState?.IsStream ?? false; + public bool IsStreaming => VoiceState?.IsStreaming ?? false; /// public DateTimeOffset? JoinedAt => DateTimeUtils.FromTicks(_joinedAtTicks); /// diff --git a/src/Discord.Net.WebSocket/Entities/Users/SocketVoiceState.cs b/src/Discord.Net.WebSocket/Entities/Users/SocketVoiceState.cs index 4d9b2ed5e..5bf36e796 100644 --- a/src/Discord.Net.WebSocket/Entities/Users/SocketVoiceState.cs +++ b/src/Discord.Net.WebSocket/Entities/Users/SocketVoiceState.cs @@ -47,7 +47,7 @@ namespace Discord.WebSocket /// public bool IsSelfDeafened => (_voiceStates & Flags.SelfDeafened) != 0; /// - public bool IsStream => (_voiceStates & Flags.SelfStream) != 0; + public bool IsStreaming => (_voiceStates & Flags.SelfStream) != 0; internal SocketVoiceState(SocketVoiceChannel voiceChannel, string sessionId, bool isSelfMuted, bool isSelfDeafened, bool isMuted, bool isDeafened, bool isSuppressed, bool isStream) { diff --git a/src/Discord.Net.WebSocket/Entities/Users/SocketWebhookUser.cs b/src/Discord.Net.WebSocket/Entities/Users/SocketWebhookUser.cs index 821b8c745..8819fe1b4 100644 --- a/src/Discord.Net.WebSocket/Entities/Users/SocketWebhookUser.cs +++ b/src/Discord.Net.WebSocket/Entities/Users/SocketWebhookUser.cs @@ -115,6 +115,6 @@ namespace Discord.WebSocket /// string IVoiceState.VoiceSessionId => null; /// - bool IVoiceState.IsStream => false; + bool IVoiceState.IsStreaming => false; } }